Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove IgnoreUnknownFields support on JsonStreamWriter #757

Merged
merged 12 commits into from Dec 30, 2020

Conversation

stephaniewang526
Copy link
Member

@stephaniewang526 stephaniewang526 commented Dec 30, 2020

Original PR opened by @yirutang : #755

IgnoreUnknownFields is no longer supported on API level. So make JsonStreamWriter consistent with it.

@stephaniewang526 stephaniewang526 requested a review from pmakani Dec 30, 2020
@product-auto-label product-auto-label bot added the api: bigquerystorage label Dec 30, 2020
@google-cla google-cla bot added the cla: yes label Dec 30, 2020
@codecov
Copy link

@codecov codecov bot commented Dec 30, 2020

Codecov Report

Merging #757 (5e979df) into master (f3c897f) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #757      +/-   ##
============================================
- Coverage     80.80%   80.80%   -0.01%     
+ Complexity      985      983       -2     
============================================
  Files            73       73              
  Lines          5289     5283       -6     
  Branches        406      404       -2     
============================================
- Hits           4274     4269       -5     
+ Misses          845      844       -1     
  Partials        170      170              
Impacted Files Coverage Δ Complexity Δ
...oud/bigquery/storage/v1beta2/JsonStreamWriter.java 77.87% <100.00%> (+0.68%) 13.00 <1.00> (+1.00)
...d/bigquery/storage/v1beta2/JsonToProtoMessage.java 96.85% <100.00%> (-0.12%) 44.00 <0.00> (-3.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3c897f...5e979df. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit 0988105 into master Dec 30, 2020
16 of 18 checks passed
@stephaniewang526 stephaniewang526 deleted the yirutang-removeignore branch Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants