Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: An extra test that is still calling old JsonStreamWriter append #760

Merged
merged 2 commits into from Jan 5, 2021

Conversation

yirutang
Copy link
Contributor

@yirutang yirutang commented Jan 5, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@yirutang yirutang requested a review from as a code owner Jan 5, 2021
@yirutang yirutang requested a review from chingor13 Jan 5, 2021
@google-cla google-cla bot added the cla: yes label Jan 5, 2021
@product-auto-label product-auto-label bot added the api: bigquerystorage label Jan 5, 2021
@yirutang yirutang changed the title fix:an extra test that is still calling old JsonStreamWriter append fix: An extra test that is still calling old JsonStreamWriter append Jan 5, 2021
@codecov
Copy link

@codecov codecov bot commented Jan 5, 2021

Codecov Report

Merging #760 (5868a3a) into master (0988105) will increase coverage by 0.01%.
The diff coverage is 82.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #760      +/-   ##
============================================
+ Coverage     80.84%   80.85%   +0.01%     
- Complexity      983      992       +9     
============================================
  Files            73       74       +1     
  Lines          5283     5333      +50     
  Branches        404      412       +8     
============================================
+ Hits           4271     4312      +41     
- Misses          843      848       +5     
- Partials        169      173       +4     
Impacted Files Coverage Δ Complexity Δ
...oud/bigquery/storage/v1beta2/JsonStreamWriter.java 78.99% <79.16%> (+1.11%) 15.00 <2.00> (+2.00)
...e/cloud/bigquery/storage/v1beta2/StreamWriter.java 85.01% <82.60%> (-0.08%) 38.00 <2.00> (+1.00) ⬇️
...uery/storage/v1beta2/BQV2ToBQStorageConverter.java 84.84% <84.84%> (ø) 6.00 <6.00> (?)
.../cloud/bigquery/storage/v1alpha2/StreamWriter.java 83.87% <0.00%> (-0.44%) 37.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 488f258...5868a3a. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit af72e6e into googleapis:master Jan 5, 2021
17 of 18 checks passed
@yirutang yirutang deleted the fix branch Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants