fix: StreamWriter hang when we reach the inflight limit control and is doing a retry #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…we try to resend a message
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: bigquerystorage
Codecov Report
@@ Coverage Diff @@
## master #799 +/- ##
============================================
+ Coverage 80.64% 81.13% +0.48%
- Complexity 992 996 +4
============================================
Files 74 74
Lines 5333 5339 +6
Branches 398 413 +15
============================================
+ Hits 4301 4332 +31
+ Misses 848 837 -11
+ Partials 184 170 -14
Continue to review full report at Codecov.
|
stephaniewang526
requested changes
Jan 15, 2021
| } catch (IOException | InterruptedException e) { | ||
| LOG.info("Got exception while retrying: " + e.toString()); | ||
| inflightBatch.onFailure(e); | ||
| abortInflightRequests(e); |
There was a problem hiding this comment.
can we add test coverage for catching these lines?
There was a problem hiding this comment.
good point. I tried this morning but couldn't figure out a good way to hit the code. I will play around a little more, but could we proceed with this first. Datalfow is waiting for a fix.
stephaniewang526
approved these changes
Jan 17, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this issue
Jan 19, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [1.8.5](https://www.github.com/googleapis/java-bigquerystorage/compare/v1.8.4...v1.8.5) (2021-01-17) ### Bug Fixes * StreamWriter hang when we reach the inflight limit control and is doing a retry ([#799](https://www.github.com/googleapis/java-bigquerystorage/issues/799)) ([f8f9770](https://www.github.com/googleapis/java-bigquerystorage/commit/f8f97701e5ca698a170a1d3b6ecb3886e186f9d5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here>☕️