Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add dataflow trace id support #827

Merged
merged 3 commits into from Feb 12, 2021
Merged

Conversation

yirutang
Copy link
Contributor

@yirutang yirutang commented Feb 11, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@yirutang yirutang requested a review from as a code owner Feb 11, 2021
@yirutang yirutang requested a review from tswast Feb 11, 2021
@product-auto-label product-auto-label bot added the api: bigquerystorage label Feb 11, 2021
@google-cla google-cla bot added the cla: yes label Feb 11, 2021
@yirutang yirutang changed the title fix:Add dataflow trace id support fix: add dataflow trace id support Feb 11, 2021
@stephaniewang526 stephaniewang526 added the kokoro:force-run label Feb 11, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Feb 11, 2021
@codecov
Copy link

@codecov codecov bot commented Feb 12, 2021

Codecov Report

Merging #827 (9026e4e) into master (36322fb) will increase coverage by 0.00%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #827   +/-   ##
=========================================
  Coverage     81.13%   81.14%           
  Complexity      996      996           
=========================================
  Files            74       74           
  Lines          5339     5346    +7     
  Branches        413      415    +2     
=========================================
+ Hits           4332     4338    +6     
- Misses          837      838    +1     
  Partials        170      170           
Impacted Files Coverage Δ Complexity Δ
...e/cloud/bigquery/storage/v1beta2/StreamWriter.java 85.00% <71.42%> (+0.01%) 38.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36322fb...71bfe4a. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit 8d22c58 into googleapis:master Feb 12, 2021
16 checks passed
@yirutang yirutang deleted the trace-id branch Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants