Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove flushAll method #850

Merged
merged 3 commits into from Feb 19, 2021
Merged

Conversation

yirutang
Copy link
Contributor

@yirutang yirutang commented Feb 18, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@yirutang yirutang requested review from as code owners Feb 18, 2021
@yirutang yirutang requested a review from tswast Feb 18, 2021
@product-auto-label product-auto-label bot added the api: bigquerystorage label Feb 18, 2021
@google-cla google-cla bot added the cla: yes label Feb 18, 2021
@codecov
Copy link

@codecov codecov bot commented Feb 18, 2021

Codecov Report

Merging #850 (8b0379c) into master (87a37d9) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #850      +/-   ##
============================================
- Coverage     80.74%   80.71%   -0.03%     
+ Complexity      990      987       -3     
============================================
  Files            74       74              
  Lines          5317     5306      -11     
  Branches        413      412       -1     
============================================
- Hits           4293     4283      -10     
+ Misses          849      848       -1     
  Partials        175      175              
Impacted Files Coverage Δ Complexity Δ
...e/cloud/bigquery/storage/v1beta2/StreamWriter.java 84.17% <ø> (+0.05%) 35.00 <0.00> (-1.00) ⬆️
.../google/cloud/bigquery/storage/v1beta2/Waiter.java 53.93% <0.00%> (-1.13%) 12.00% <0.00%> (-2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87a37d9...ac22732. Read the comment docs.

@stephaniewang526 stephaniewang526 added the automerge label Feb 18, 2021
@gcf-merge-on-green
Copy link

@gcf-merge-on-green gcf-merge-on-green bot commented Feb 19, 2021

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Feb 19, 2021
@stephaniewang526 stephaniewang526 merged commit 33a4502 into googleapis:master Feb 19, 2021
16 checks passed
*
* @throws Exception
*/
public void flushAll(long timeoutMillis) throws Exception {
Copy link
Member

@suztomo suztomo Feb 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yirutang Would you explain whether this removal is a backward compatible change from the library users's perspective?

(I'm surveying how much CLIRR helps Java libraries to follow semantic versioning or not)

Copy link
Contributor Author

@yirutang yirutang Feb 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of now I am pretty sure, there is no user on this. We would eventually provide this method but there is still some dispute about this.

Copy link
Member

@suztomo suztomo Feb 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Thanks.

@yirutang yirutang deleted the remove-flushall branch Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants