Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: temporally disable refreshAppend #853

Merged
merged 5 commits into from Feb 19, 2021

Conversation

yirutang
Copy link
Contributor

@yirutang yirutang commented Feb 18, 2021

Will try to add it back in after we sort out the inflight queue stuff.

@yirutang yirutang requested a review from as a code owner Feb 18, 2021
@yirutang yirutang requested a review from stephaniewang526 Feb 18, 2021
@product-auto-label product-auto-label bot added the api: bigquerystorage label Feb 18, 2021
@google-cla google-cla bot added the cla: yes label Feb 18, 2021
@yirutang
Copy link
Contributor Author

@yirutang yirutang commented Feb 18, 2021

Waiting on yayi's approval.

@codecov
Copy link

@codecov codecov bot commented Feb 18, 2021

Codecov Report

Merging #853 (ba374b4) into master (6021920) will decrease coverage by 0.47%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #853      +/-   ##
============================================
- Coverage     80.74%   80.26%   -0.48%     
+ Complexity      990      982       -8     
============================================
  Files            74       74              
  Lines          5317     5301      -16     
  Branches        413      410       -3     
============================================
- Hits           4293     4255      -38     
- Misses          849      873      +24     
+ Partials        175      173       -2     
Impacted Files Coverage Δ Complexity Δ
...e/cloud/bigquery/storage/v1beta2/StreamWriter.java 82.83% <0.00%> (-1.29%) 33.00 <0.00> (-3.00)
...gquery/storage/v1beta2/OnSchemaUpdateRunnable.java 42.85% <0.00%> (-42.86%) 2.00% <0.00%> (-2.00%)
...oud/bigquery/storage/v1beta2/JsonStreamWriter.java 65.54% <0.00%> (-13.45%) 12.00% <0.00%> (-3.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6021920...c089f6a. Read the comment docs.

yirutang added 3 commits Feb 19, 2021
This reverts commit 9a29abe.
@stephaniewang526 stephaniewang526 merged commit baf973d into googleapis:master Feb 19, 2021
16 checks passed
@yirutang yirutang deleted the append-lock branch Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants