Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(samples): add a new sample for parallel append #863

Merged
merged 7 commits into from Feb 23, 2021

Conversation

yayi-google
Copy link
Contributor

@yayi-google yayi-google commented Feb 19, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@yayi-google yayi-google requested review from yirutang and Feb 19, 2021
@product-auto-label product-auto-label bot added api: bigquerystorage samples labels Feb 19, 2021
@snippet-bot
Copy link

@snippet-bot snippet-bot bot commented Feb 19, 2021

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cla google-cla bot added the cla: yes label Feb 19, 2021
@yayi-google yayi-google changed the title Add a new sample for parallel append. feat: add a new sample for parallel append. Feb 19, 2021
@yayi-google yayi-google changed the title feat: add a new sample for parallel append. feat: add a new sample for parallel append Feb 19, 2021
@codecov
Copy link

@codecov codecov bot commented Feb 19, 2021

Codecov Report

Merging #863 (b93679c) into master (3a942cd) will increase coverage by 0.39%.
The diff coverage is 95.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #863      +/-   ##
============================================
+ Coverage     80.24%   80.64%   +0.39%     
- Complexity      979     1005      +26     
============================================
  Files            74       76       +2     
  Lines          5290     5430     +140     
  Branches        409      420      +11     
============================================
+ Hits           4245     4379     +134     
- Misses          872      878       +6     
  Partials        173      173              
Impacted Files Coverage Δ Complexity Δ
...cloud/bigquery/storage/v1beta2/StreamWriterV2.java 94.95% <94.95%> (ø) 23.00 <23.00> (?)
...oud/bigquery/storage/v1beta2/StreamConnection.java 100.00% <100.00%> (ø) 3.00 <3.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a942cd...cdbeaf3. Read the comment docs.

@yayi-google
Copy link
Contributor Author

@yayi-google yayi-google commented Feb 22, 2021

The only one failing test is unrelated to this CL, and is removed in a separate pull request.

@stephaniewang526
Copy link
Member

@stephaniewang526 stephaniewang526 commented Feb 23, 2021

please change the subject and initial commit from feat: ... to docs(samples): ... since this is not a feat and it will go into the release notes.

@yayi-google yayi-google changed the title feat: add a new sample for parallel append docs(samples): add a new sample for parallel append Feb 23, 2021
@stephaniewang526 stephaniewang526 added the automerge label Feb 23, 2021
@stephaniewang526 stephaniewang526 merged commit ed1c265 into googleapis:master Feb 23, 2021
16 of 17 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage cla: yes samples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants