feat: Create Stream writer v2 - starting with core logics #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compared to existing StreamWriter, its locking mechanism is much simpler.
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: bigquerystorage
bigang-li
reviewed
Feb 21, 2021
...querystorage/src/test/java/com/google/cloud/bigquery/storage/v1beta2/StreamWriterV2Test.java
Show resolved
Hide resolved
...-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/StreamWriterV2.java
Outdated
Show resolved
Hide resolved
...-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/StreamWriterV2.java
Outdated
Show resolved
Hide resolved
...-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/StreamWriterV2.java
Outdated
Show resolved
Hide resolved
...-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/StreamWriterV2.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #867 +/- ##
============================================
+ Coverage 80.03% 80.64% +0.60%
- Complexity 979 1005 +26
============================================
Files 74 76 +2
Lines 5290 5430 +140
Branches 408 420 +12
============================================
+ Hits 4234 4379 +145
- Misses 872 878 +6
+ Partials 184 173 -11
Continue to review full report at Codecov.
|
yirutang
reviewed
Feb 22, 2021
...rystorage/src/test/java/com/google/cloud/bigquery/storage/v1beta2/FakeBigQueryWriteImpl.java
Show resolved
Hide resolved
...-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/StreamWriterV2.java
Show resolved
Hide resolved
...-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/StreamWriterV2.java
Show resolved
Hide resolved
...-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/StreamWriterV2.java
Show resolved
Hide resolved
yirutang
reviewed
Feb 22, 2021
...querystorage/src/test/java/com/google/cloud/bigquery/storage/v1beta2/StreamWriterV2Test.java
Show resolved
Hide resolved
yirutang
reviewed
Feb 23, 2021
...-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/StreamWriterV2.java
Show resolved
Hide resolved
...-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/StreamWriterV2.java
Show resolved
Hide resolved
...-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/StreamWriterV2.java
Show resolved
Hide resolved
yirutang
approved these changes
Feb 23, 2021
bigang-li
approved these changes
Feb 23, 2021
| log.info("User closing stream: " + streamName); | ||
| this.lock.lock(); | ||
| try { | ||
| this.userClosed = true; |
There was a problem hiding this comment.
adding a local var to remember the previous value, so if user closed twice, the second time will be no_op (don't call the appendThread.join() multiple times).
|
|
||
| if (localQueue.isEmpty()) { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
maybe be save a few lines of code here? it's useless according to context.
stephaniewang526
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Unblocks Dataflow sink test which unblocks customer update.