Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add max size check to StreamWriterV2 #873

Merged
merged 6 commits into from Feb 23, 2021

Conversation

yayi-google
Copy link
Contributor

@yayi-google yayi-google commented Feb 23, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@yayi-google yayi-google requested a review from yirutang Feb 23, 2021
@yayi-google yayi-google requested a review from as a code owner Feb 23, 2021
@yayi-google yayi-google requested a review from shollyman Feb 23, 2021
@product-auto-label product-auto-label bot added the api: bigquerystorage label Feb 23, 2021
@google-cla google-cla bot added the cla: yes label Feb 23, 2021
@yayi-google yayi-google removed the request for review from shollyman Feb 23, 2021
@codecov
Copy link

@codecov codecov bot commented Feb 23, 2021

Codecov Report

Merging #873 (a2177c7) into master (ed1c265) will increase coverage by 0.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #873      +/-   ##
============================================
+ Coverage     80.42%   80.67%   +0.24%     
- Complexity     1005     1007       +2     
============================================
  Files            76       76              
  Lines          5430     5438       +8     
  Branches        419      421       +2     
============================================
+ Hits           4367     4387      +20     
  Misses          878      878              
+ Partials        185      173      -12     
Impacted Files Coverage Δ Complexity Δ
...cloud/bigquery/storage/v1beta2/StreamWriterV2.java 95.27% <100.00%> (+1.15%) 25.00 <1.00> (+2.00)
...ery/storage/v1beta1/BaseBigQueryStorageClient.java 72.88% <0.00%> (+1.69%) 22.00% <0.00%> (ø%)
...ud/bigquery/storage/v1/BaseBigQueryReadClient.java 60.97% <0.00%> (+2.43%) 12.00% <0.00%> (ø%)
...gquery/storage/v1beta2/BaseBigQueryReadClient.java 60.97% <0.00%> (+2.43%) 12.00% <0.00%> (ø%)
.../bigquery/storage/v1beta2/BigQueryWriteClient.java 75.38% <0.00%> (+4.61%) 33.00% <0.00%> (ø%)
...bigquery/storage/v1alpha2/BigQueryWriteClient.java 80.51% <0.00%> (+6.49%) 38.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed1c265...2c47c6a. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit 0261af4 into googleapis:master Feb 23, 2021
15 of 16 checks passed
@yayi-google yayi-google deleted the max-size-check branch Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants