Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support building a BigQueryWriteClient within the StreamWriterV2 #876

Merged
merged 4 commits into from Feb 24, 2021

Conversation

yayi-google
Copy link
Contributor

@yayi-google yayi-google commented Feb 23, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@yayi-google yayi-google requested a review from as a code owner Feb 23, 2021
@yayi-google yayi-google requested a review from tswast Feb 23, 2021
@google-cla google-cla bot added the cla: yes label Feb 23, 2021
@product-auto-label product-auto-label bot added the api: bigquerystorage label Feb 23, 2021
@yayi-google yayi-google requested review from yirutang and removed request for tswast Feb 23, 2021
@yayi-google yayi-google changed the title feat: Support building a BigQueryWriteClient within the StreamWriterV2. feat: Support building a BigQueryWriteClient within the StreamWriterV2 Feb 23, 2021
@codecov
Copy link

@codecov codecov bot commented Feb 23, 2021

Codecov Report

Merging #876 (0a7324a) into master (854c81e) will increase coverage by 4.53%.
The diff coverage is 94.11%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #876      +/-   ##
============================================
+ Coverage     76.32%   80.85%   +4.53%     
- Complexity      967     1014      +47     
============================================
  Files            76       76              
  Lines          4156     5500    +1344     
  Branches        368      423      +55     
============================================
+ Hits           3172     4447    +1275     
- Misses          814      880      +66     
- Partials        170      173       +3     
Impacted Files Coverage Δ Complexity Δ
...cloud/bigquery/storage/v1beta2/StreamWriterV2.java 95.76% <94.11%> (-1.32%) 32.00 <1.00> (+3.00) ⬇️
.../cloud/bigquery/storage/v1alpha2/DirectWriter.java 77.55% <0.00%> (-1.52%) 6.00% <0.00%> (ø%)
...y/storage/v1beta1/BaseBigQueryStorageSettings.java 18.42% <0.00%> (-1.03%) 2.00% <0.00%> (ø%)
...loud/bigquery/storage/v1/BigQueryReadSettings.java 23.52% <0.00%> (-0.72%) 3.00% <0.00%> (ø%)
...bigquery/storage/v1beta2/BigQueryReadSettings.java 23.52% <0.00%> (-0.72%) 3.00% <0.00%> (ø%)
...igquery/storage/v1beta2/BigQueryWriteSettings.java 25.64% <0.00%> (-0.68%) 5.00% <0.00%> (ø%)
...gquery/storage/v1alpha2/BigQueryWriteSettings.java 25.64% <0.00%> (-0.68%) 5.00% <0.00%> (ø%)
.../bigquery/storage/v1/BaseBigQueryReadSettings.java 21.21% <0.00%> (-0.67%) 2.00% <0.00%> (ø%)
...uery/storage/v1beta2/BaseBigQueryReadSettings.java 21.21% <0.00%> (-0.67%) 2.00% <0.00%> (ø%)
...query/storage/v1beta1/BigQueryStorageSettings.java 21.05% <0.00%> (-0.57%) 3.00% <0.00%> (ø%)
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 854c81e...7ef59f0. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit 237c827 into googleapis:master Feb 24, 2021
15 of 16 checks passed
@yayi-google yayi-google deleted the creds branch Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants