Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: StreamWriterV2 will handle schema/streamName attachment #877

Merged
merged 3 commits into from Feb 25, 2021

Conversation

yayi-google
Copy link
Contributor

@yayi-google yayi-google commented Feb 24, 2021

…the connection and remove stream name and schema in the following ones.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

…the connection and remove stream name and schema in the following ones.
@yayi-google yayi-google requested a review from as a code owner Feb 24, 2021
@yayi-google yayi-google requested a review from tswast Feb 24, 2021
@product-auto-label product-auto-label bot added the api: bigquerystorage label Feb 24, 2021
@google-cla google-cla bot added the cla: yes label Feb 24, 2021
@yayi-google yayi-google requested review from yirutang and removed request for tswast Feb 24, 2021
@codecov
Copy link

@codecov codecov bot commented Feb 24, 2021

Codecov Report

Merging #877 (be27cbc) into master (237c827) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #877      +/-   ##
============================================
+ Coverage     80.85%   80.89%   +0.04%     
- Complexity     1014     1016       +2     
============================================
  Files            76       76              
  Lines          5500     5512      +12     
  Branches        423      424       +1     
============================================
+ Hits           4447     4459      +12     
  Misses          880      880              
  Partials        173      173              
Impacted Files Coverage Δ Complexity Δ
...cloud/bigquery/storage/v1beta2/StreamWriterV2.java 96.01% <100.00%> (+0.25%) 34.00 <7.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 237c827...be27cbc. Read the comment docs.

@yirutang yirutang self-requested a review Feb 24, 2021
@yayi-google yayi-google added status: investigating and removed status: investigating labels Feb 24, 2021
@stephaniewang526 stephaniewang526 merged commit c54bcfe into master Feb 25, 2021
18 checks passed
@stephaniewang526 stephaniewang526 deleted the schema-stream-name branch Feb 25, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Mar 1, 2021
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.13.0](https://www.github.com/googleapis/java-bigquerystorage/compare/v1.12.0...v1.13.0) (2021-03-01)


### Features

* **generator:** update protoc to v3.15.3 ([#898](https://www.github.com/googleapis/java-bigquerystorage/issues/898)) ([2f277d6](https://www.github.com/googleapis/java-bigquerystorage/commit/2f277d650e8f617c6253843baf73d5d220713a61))
* in StreamWriterV2, supports new append, which takes rows and offset ([#894](https://www.github.com/googleapis/java-bigquerystorage/issues/894)) ([f3865b0](https://www.github.com/googleapis/java-bigquerystorage/commit/f3865b06ea7c61e95d3ee9bc7b46857d9d3080cc))
* StreamWriterV2 will handle schema/streamName attachment ([#877](https://www.github.com/googleapis/java-bigquerystorage/issues/877)) ([c54bcfe](https://www.github.com/googleapis/java-bigquerystorage/commit/c54bcfec1706eef58eaf9dad8b49dc79fc8da133))


### Dependencies

* update dependency com.google.cloud:google-cloud-bigquery to v1.127.5 ([#896](https://www.github.com/googleapis/java-bigquerystorage/issues/896)) ([d211c76](https://www.github.com/googleapis/java-bigquerystorage/commit/d211c76dff747121d4560b55818c10bf595ef1c3))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.20.0 ([#892](https://www.github.com/googleapis/java-bigquerystorage/issues/892)) ([438f1c3](https://www.github.com/googleapis/java-bigquerystorage/commit/438f1c3b551e6b97a3241c69f2006a5a6be78c4f))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants