Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(sample): Update parallel append sample to use StreamWriterV2 #883

Merged
merged 6 commits into from Feb 25, 2021

Conversation

yayi-google
Copy link
Contributor

@yayi-google yayi-google commented Feb 24, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@yayi-google yayi-google requested a review from Feb 24, 2021
@google-cla google-cla bot added the cla: yes label Feb 24, 2021
@product-auto-label product-auto-label bot added the api: bigquerystorage label Feb 24, 2021
@yayi-google yayi-google requested a review from yirutang Feb 24, 2021
@product-auto-label product-auto-label bot added the samples label Feb 24, 2021
lesv
lesv approved these changes Feb 24, 2021
Copy link

@lesv lesv left a comment

I don't see region tags anywhere and you appear to have added a example w/o a test.

  • You should consider adding an IT test before committing.
  • You should consider adding region tags before committing.

@codecov
Copy link

@codecov codecov bot commented Feb 24, 2021

Codecov Report

Merging #883 (8a7da6d) into master (8e2ab01) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #883   +/-   ##
=========================================
  Coverage     80.85%   80.85%           
  Complexity     1014     1014           
=========================================
  Files            76       76           
  Lines          5500     5500           
  Branches        423      423           
=========================================
  Hits           4447     4447           
  Misses          880      880           
  Partials        173      173           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e2ab01...8a7da6d. Read the comment docs.

@yayi-google
Copy link
Contributor Author

@yayi-google yayi-google commented Feb 24, 2021

I don't see region tags anywhere and you appear to have added a example w/o a test.

  • You should consider adding an IT test before committing.
  • You should consider adding region tags before committing.

We have IT test in the test fold.
We have region tags at the line 19.

@lesv
Copy link

@lesv lesv commented Feb 25, 2021

Sg - that's why I gave a LGTM - I just have to ask. L19 wasn't shown in the PR

@stephaniewang526 stephaniewang526 merged commit 5c5c690 into master Feb 25, 2021
19 checks passed
@stephaniewang526 stephaniewang526 deleted the migrate-sample branch Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage cla: yes samples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants