Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: StreamWriterV2 sets exception for response with error #884

Merged
merged 1 commit into from Feb 25, 2021

Conversation

yayi-google
Copy link
Contributor

@yayi-google yayi-google commented Feb 25, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@yayi-google yayi-google requested a review from as a code owner Feb 25, 2021
@yayi-google yayi-google requested a review from steffnay Feb 25, 2021
@google-cla google-cla bot added the cla: yes label Feb 25, 2021
@product-auto-label product-auto-label bot added the api: bigquerystorage label Feb 25, 2021
@yayi-google yayi-google requested review from yirutang and removed request for steffnay Feb 25, 2021
@codecov
Copy link

@codecov codecov bot commented Feb 25, 2021

Codecov Report

Merging #884 (5807dbf) into master (8e2ab01) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #884      +/-   ##
============================================
+ Coverage     80.85%   80.87%   +0.02%     
- Complexity     1014     1015       +1     
============================================
  Files            76       76              
  Lines          5500     5506       +6     
  Branches        423      424       +1     
============================================
+ Hits           4447     4453       +6     
  Misses          880      880              
  Partials        173      173              
Impacted Files Coverage Δ Complexity Δ
...cloud/bigquery/storage/v1beta2/StreamWriterV2.java 95.89% <100.00%> (+0.13%) 33.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e2ab01...5807dbf. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit 4677d7b into master Feb 25, 2021
18 checks passed
@stephaniewang526 stephaniewang526 deleted the exception-on-error branch Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants