Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: testAppendWhileShutdownSuccess race #907

Merged
merged 3 commits into from Mar 3, 2021

Conversation

yirutang
Copy link
Contributor

@yirutang yirutang commented Mar 3, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@yirutang yirutang requested a review from as a code owner Mar 3, 2021
@yirutang yirutang requested a review from tswast Mar 3, 2021
@product-auto-label product-auto-label bot added the api: bigquerystorage label Mar 3, 2021
@google-cla google-cla bot added the cla: yes label Mar 3, 2021
@yirutang yirutang changed the title fix:testAppendWhileShutdownSuccess race fix: testAppendWhileShutdownSuccess race Mar 3, 2021
@codecov
Copy link

@codecov codecov bot commented Mar 3, 2021

Codecov Report

Merging #907 (4f786fd) into master (7c1bb12) will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #907      +/-   ##
============================================
- Coverage     80.38%   80.21%   -0.17%     
  Complexity     1015     1015              
============================================
  Files            76       76              
  Lines          5576     5570       -6     
  Branches        436      420      -16     
============================================
- Hits           4482     4468      -14     
+ Misses          916      913       -3     
- Partials        178      189      +11     
Impacted Files Coverage Δ Complexity Δ
...e/cloud/bigquery/storage/v1beta2/StreamWriter.java 79.59% <ø> (+0.39%) 31.00 <0.00> (ø)
...bigquery/storage/v1alpha2/BigQueryWriteClient.java 74.02% <0.00%> (-6.50%) 38.00% <0.00%> (ø%)
.../bigquery/storage/v1beta2/BigQueryWriteClient.java 70.76% <0.00%> (-4.62%) 33.00% <0.00%> (ø%)
...ud/bigquery/storage/v1/BaseBigQueryReadClient.java 58.53% <0.00%> (-2.44%) 12.00% <0.00%> (ø%)
...gquery/storage/v1beta2/BaseBigQueryReadClient.java 58.53% <0.00%> (-2.44%) 12.00% <0.00%> (ø%)
...ery/storage/v1beta1/BaseBigQueryStorageClient.java 71.18% <0.00%> (-1.70%) 22.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c1bb12...f9aa2aa. Read the comment docs.

@stephaniewang526
Copy link
Member

@stephaniewang526 stephaniewang526 commented Mar 3, 2021

Error:  Failures: 
Error:    StreamWriterTest.testAppendWhileShutdownSuccess:767 Call got exception: java.util.concurrent.ExecutionException: java.lang.IllegalStateException: The append result offset 3 does not match the expected offset 5.

Seem like additional changes are required here.

@stephaniewang526 stephaniewang526 merged commit d39443d into googleapis:master Mar 3, 2021
16 checks passed
gcf-merge-on-green bot pushed a commit that referenced this issue Mar 4, 2021
🤖 I have created a release \*beep\* \*boop\*
---
## [1.14.0](https://www.github.com/googleapis/java-bigquerystorage/compare/v1.13.0...v1.14.0) (2021-03-04)


### Features

* update StreamWriterV2 to support trace id ([#895](https://www.github.com/googleapis/java-bigquerystorage/issues/895)) ([2e49ce8](https://www.github.com/googleapis/java-bigquerystorage/commit/2e49ce8c79cb059840c3307898ba16980f6892fa))


### Bug Fixes

* add schema update back to json writer ([#905](https://www.github.com/googleapis/java-bigquerystorage/issues/905)) ([a2adbf8](https://www.github.com/googleapis/java-bigquerystorage/commit/a2adbf80753161cbddd23d5a7db75e9250db58fa))
* Add unit test for concurrent issues we worried about, and fix some locking issues ([#854](https://www.github.com/googleapis/java-bigquerystorage/issues/854)) ([0870797](https://www.github.com/googleapis/java-bigquerystorage/commit/087079728195e20f93701e8d5e1e59ba29a7d21b))
* test failure testAppendWhileShutdownSuccess ([#904](https://www.github.com/googleapis/java-bigquerystorage/issues/904)) ([b80183e](https://www.github.com/googleapis/java-bigquerystorage/commit/b80183ea23c8b78611a42d22d8c62a4ba4904a80))
* testAppendWhileShutdownSuccess race ([#907](https://www.github.com/googleapis/java-bigquerystorage/issues/907)) ([d39443d](https://www.github.com/googleapis/java-bigquerystorage/commit/d39443d51d2625e4b3aee59d1e593229e9e449d3))


### Dependencies

* update dependency com.google.cloud:google-cloud-bigquery to v1.127.6 ([#909](https://www.github.com/googleapis/java-bigquerystorage/issues/909)) ([505938b](https://www.github.com/googleapis/java-bigquerystorage/commit/505938bcba5a4a7af9e618572bbc41f365702f47))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants