Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a deprecation message on StreamWriter #922

Merged
merged 3 commits into from Mar 24, 2021

Conversation

yirutang
Copy link
Contributor

@yirutang yirutang commented Mar 5, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@yirutang yirutang requested a review from as a code owner Mar 5, 2021
@yirutang yirutang requested a review from tswast Mar 5, 2021
@product-auto-label product-auto-label bot added the api: bigquerystorage label Mar 5, 2021
@google-cla google-cla bot added the cla: yes label Mar 5, 2021
@codecov
Copy link

@codecov codecov bot commented Mar 5, 2021

Codecov Report

Merging #922 (dbf87a6) into master (ed33785) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #922      +/-   ##
============================================
- Coverage     80.99%   80.92%   -0.08%     
+ Complexity     1021     1020       -1     
============================================
  Files            76       76              
  Lines          5556     5556              
  Branches        426      426              
============================================
- Hits           4500     4496       -4     
- Misses          879      884       +5     
+ Partials        177      176       -1     
Impacted Files Coverage Δ Complexity Δ
...e/cloud/bigquery/storage/v1beta2/StreamWriter.java 82.33% <ø> (-0.92%) 32.00 <0.00> (-1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed33785...b27fd2e. Read the comment docs.

@stephaniewang526 stephaniewang526 added the status: investigating label Mar 9, 2021
@stephaniewang526
Copy link
Member

@stephaniewang526 stephaniewang526 commented Mar 9, 2021

We will come back to this once we finalized the deprecation process.

@yirutang
Copy link
Contributor Author

@yirutang yirutang commented Mar 24, 2021

This is on beta API which we are going to launch in end of March.

@stephaniewang526 stephaniewang526 merged commit fce5289 into googleapis:master Mar 24, 2021
16 checks passed
gcf-merge-on-green bot pushed a commit that referenced this issue Mar 25, 2021
🤖 I have created a release \*beep\* \*boop\*
---
## [1.16.0](https://www.github.com/googleapis/java-bigquerystorage/compare/v1.15.1...v1.16.0) (2021-03-25)


### Features

* Add CivilTimeEncoder to encode and decode DateTime/Time as numerics ([#937](https://www.github.com/googleapis/java-bigquerystorage/issues/937)) ([969b429](https://www.github.com/googleapis/java-bigquerystorage/commit/969b4290b9934b94b1a0113e04e37ff44b2a536e))


### Bug Fixes

* add a deprecation message on StreamWriter ([#922](https://www.github.com/googleapis/java-bigquerystorage/issues/922)) ([fce5289](https://www.github.com/googleapis/java-bigquerystorage/commit/fce52890c6948a9b78a62d2fe0e4f9768d10d401))


### Dependencies

* update dependency com.google.cloud:google-cloud-bigquery to v1.127.10 ([#955](https://www.github.com/googleapis/java-bigquerystorage/issues/955)) ([c810c72](https://www.github.com/googleapis/java-bigquerystorage/commit/c810c7279bfbad31cb0f94f5ad5d4a74342d4481))
* update dependency com.google.cloud:google-cloud-bigquery to v1.127.9 ([#947](https://www.github.com/googleapis/java-bigquerystorage/issues/947)) ([d781dc5](https://www.github.com/googleapis/java-bigquerystorage/commit/d781dc5479602fee01eb971033978317e5669694))


### Documentation

* **samples:** Check for error from BatchCommitWriteStreams ([#940](https://www.github.com/googleapis/java-bigquerystorage/issues/940)) ([ab3c145](https://www.github.com/googleapis/java-bigquerystorage/commit/ab3c1453d3c1fb627e773d0e7ca4ec991f8d38b7))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@yirutang yirutang deleted the streamwriter branch Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage cla: yes status: investigating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants