feat!: remove deprecated append method in StreamWriterV2 #924
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
@@ Coverage Diff @@ ## master #924 +/- ## ============================================ - Coverage 80.99% 80.95% -0.04% Complexity 1021 1021 ============================================ Files 76 76 Lines 5556 5556 Branches 426 427 +1 ============================================ - Hits 4500 4498 -2 - Misses 879 881 +2 Partials 177 177
Also this is breaking binary compatability:
To fix this, we need to modify this file -- we can delete these once the client is released (meaning new baseline is established for binary compat check).
Done. Thank you!…
On Tue, Mar 9, 2021 at 8:14 AM Stephanie Wang ***@***.***> wrote: Also this is breaking binary compatability: Error: 7002: com.google.cloud.bigquery.storage.v1beta2.StreamWriterV2: Method 'public com.google.api.core.ApiFuture append(com.google.cloud.bigquery.storage.v1beta2.AppendRowsRequest)' has been removed To fix this, we need to modify this file <https://github.com/googleapis/java-bigquerystorage/blob/master/google-cloud-bigquerystorage/clirr-ignored-differences.xml> -- we can delete these once the client is released (meaning new baseline is established for binary compat check). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#924 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASBQVIOKXPB6XHRIA2TCNTDTCY3NHANCNFSM4YWIDM3A> .
gcf-merge-on-green bot pushed a commit that referenced this issue
Mar 10, 2021
🤖I have created a release \*beep\* \*boop\* --- ## [2.0.0](https://www.github.com/googleapis/java-bigquerystorage/compare/v1.14.0...v2.0.0) (2021-03-09) ### ⚠BREAKING CHANGES * remove deprecated append method in StreamWriterV2 (#924) ### Features * remove deprecated append method in StreamWriterV2 ([#924](https://www.github.com/googleapis/java-bigquerystorage/issues/924)) ([f278775](https://www.github.com/googleapis/java-bigquerystorage/commit/f2787751bf03d91d1575ee6e007f407f91d97157)) ### Bug Fixes * Revive schema update e2e test and adjust some test names ([#921](https://www.github.com/googleapis/java-bigquerystorage/issues/921)) ([dd392e5](https://www.github.com/googleapis/java-bigquerystorage/commit/dd392e54953e0b75e780532a4dab2d143b8d8665)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.20.1 ([#931](https://www.github.com/googleapis/java-bigquerystorage/issues/931)) ([8c716c5](https://www.github.com/googleapis/java-bigquerystorage/commit/8c716c5d26420ef03f76a302c76892894045d4ad)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.