Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove deprecated append method in StreamWriterV2 #924

Merged
merged 3 commits into from Mar 9, 2021

Conversation

yayi-google
Copy link
Contributor

@yayi-google yayi-google commented Mar 6, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@yayi-google yayi-google requested review from yirutang and bigang-li Mar 6, 2021
@yayi-google yayi-google requested a review from as a code owner Mar 6, 2021
@yayi-google yayi-google requested review from and stephaniewang526 Mar 6, 2021
@product-auto-label product-auto-label bot added the api: bigquerystorage label Mar 6, 2021
@google-cla google-cla bot added the cla: yes label Mar 6, 2021
@codecov
Copy link

@codecov codecov bot commented Mar 6, 2021

Codecov Report

Merging #924 (27c5a78) into master (ed33785) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #924      +/-   ##
============================================
- Coverage     80.99%   80.95%   -0.04%     
  Complexity     1021     1021              
============================================
  Files            76       76              
  Lines          5556     5556              
  Branches        426      427       +1     
============================================
- Hits           4500     4498       -2     
- Misses          879      881       +2     
  Partials        177      177              
Impacted Files Coverage Δ Complexity Δ
...cloud/bigquery/storage/v1beta2/StreamWriterV2.java 96.10% <100.00%> (ø) 39.00 <0.00> (ø)
...e/cloud/bigquery/storage/v1beta2/StreamWriter.java 82.79% <0.00%> (-0.46%) 33.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed33785...5bdca0e. Read the comment docs.

@stephaniewang526
Copy link
Member

@stephaniewang526 stephaniewang526 commented Mar 8, 2021

Hi @yayi-google -- the change is fine but the PR needs to be feat!: since it indicates a major breaking change.

Please update both the PR subject and the initial commit (which will be used in the release notes).

@yayi-google yayi-google changed the title refactor!: remove deprecated append method in StreamWriterV2 feat!: remove deprecated append method in StreamWriterV2 Mar 8, 2021
@yayi-google
Copy link
Contributor Author

@yayi-google yayi-google commented Mar 8, 2021

Hi @yayi-google -- the change is fine but the PR needs to be feat!: since it indicates a major breaking change.

Please update both the PR subject and the initial commit (which will be used in the release notes).

Done. Thank you!

@stephaniewang526
Copy link
Member

@stephaniewang526 stephaniewang526 commented Mar 9, 2021

Also this is breaking binary compatability:

Error:  7002: com.google.cloud.bigquery.storage.v1beta2.StreamWriterV2: Method 'public com.google.api.core.ApiFuture append(com.google.cloud.bigquery.storage.v1beta2.AppendRowsRequest)' has been removed

To fix this, we need to modify this file -- we can delete these once the client is released (meaning new baseline is established for binary compat check).

@yayi-google yayi-google requested a review from as a code owner Mar 9, 2021
@yayi-google
Copy link
Contributor Author

@yayi-google yayi-google commented Mar 9, 2021

@stephaniewang526 stephaniewang526 merged commit f278775 into master Mar 9, 2021
17 checks passed
@stephaniewang526 stephaniewang526 deleted the use-new-append branch Mar 9, 2021
@release-please release-please bot mentioned this pull request Mar 9, 2021
@stephaniewang526 stephaniewang526 restored the use-new-append branch Mar 10, 2021
@stephaniewang526 stephaniewang526 deleted the use-new-append branch Mar 10, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Mar 10, 2021
🤖 I have created a release \*beep\* \*boop\*
---
## [2.0.0](https://www.github.com/googleapis/java-bigquerystorage/compare/v1.14.0...v2.0.0) (2021-03-09)


###  BREAKING CHANGES

* remove deprecated append method in StreamWriterV2 (#924)

### Features

* remove deprecated append method in StreamWriterV2 ([#924](https://www.github.com/googleapis/java-bigquerystorage/issues/924)) ([f278775](https://www.github.com/googleapis/java-bigquerystorage/commit/f2787751bf03d91d1575ee6e007f407f91d97157))


### Bug Fixes

* Revive schema update e2e test and adjust some test names ([#921](https://www.github.com/googleapis/java-bigquerystorage/issues/921)) ([dd392e5](https://www.github.com/googleapis/java-bigquerystorage/commit/dd392e54953e0b75e780532a4dab2d143b8d8665))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.20.1 ([#931](https://www.github.com/googleapis/java-bigquerystorage/issues/931)) ([8c716c5](https://www.github.com/googleapis/java-bigquerystorage/commit/8c716c5d26420ef03f76a302c76892894045d4ad))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants