Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add deprecated annotation and tag to bq storage alpha api #978

Merged
merged 4 commits into from Apr 5, 2021

Conversation

yirutang
Copy link
Contributor

@yirutang yirutang commented Mar 31, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@yirutang yirutang requested a review from as a code owner Mar 31, 2021
@yirutang yirutang requested a review from shollyman Mar 31, 2021
@generated-files-bot
Copy link

@generated-files-bot generated-files-bot bot commented Mar 31, 2021

Warning: This pull request is touching the following templated files:

  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/BigQueryWriteClient.java
  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/BigQueryWriteSettings.java

@google-cla google-cla bot added the cla: yes label Mar 31, 2021
@product-auto-label product-auto-label bot added the api: bigquerystorage label Mar 31, 2021
@yirutang yirutang requested a review from stephaniewang526 Mar 31, 2021
@codecov
Copy link

@codecov codecov bot commented Apr 1, 2021

Codecov Report

Merging #978 (1fba6e5) into master (ed33785) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #978      +/-   ##
============================================
- Coverage     80.99%   80.96%   -0.04%     
- Complexity     1021     1043      +22     
============================================
  Files            76       78       +2     
  Lines          5556     5657     +101     
  Branches        426      433       +7     
============================================
+ Hits           4500     4580      +80     
- Misses          879      890      +11     
- Partials        177      187      +10     
Impacted Files Coverage Δ Complexity Δ
...orage/v1alpha2/BQTableSchemaToProtoDescriptor.java 98.48% <ø> (ø) 8.00 <0.00> (ø)
.../cloud/bigquery/storage/v1alpha2/DirectWriter.java 77.55% <ø> (ø) 6.00 <0.00> (ø)
...ud/bigquery/storage/v1alpha2/JsonStreamWriter.java 77.19% <ø> (ø) 12.00 <0.00> (ø)
.../bigquery/storage/v1alpha2/JsonToProtoMessage.java 96.96% <ø> (ø) 47.00 <0.00> (ø)
...oud/bigquery/storage/v1alpha2/JsonWriterCache.java 91.07% <ø> (ø) 12.00 <0.00> (ø)
...query/storage/v1alpha2/OnSchemaUpdateRunnable.java 85.71% <ø> (ø) 4.00 <0.00> (ø)
...igquery/storage/v1alpha2/ProtoSchemaConverter.java 96.22% <ø> (ø) 10.00 <0.00> (ø)
...bigquery/storage/v1alpha2/SchemaCompatibility.java 91.30% <ø> (ø) 99.00 <0.00> (ø)
.../cloud/bigquery/storage/v1alpha2/StreamWriter.java 79.95% <ø> (-0.44%) 34.00 <0.00> (ø)
...google/cloud/bigquery/storage/v1alpha2/Waiter.java 55.95% <ø> (ø) 12.00 <0.00> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed33785...1fba6e5. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit c7da342 into googleapis:master Apr 5, 2021
17 of 18 checks passed
gcf-merge-on-green bot pushed a commit that referenced this issue Apr 9, 2021
🤖 I have created a release \*beep\* \*boop\*
---
## [1.18.0](https://www.github.com/googleapis/java-bigquerystorage/compare/v1.17.0...v1.18.0) (2021-04-09)


### Features

* add deprecated annotation and tag to bq storage alpha api ([#978](https://www.github.com/googleapis/java-bigquerystorage/issues/978)) ([c7da342](https://www.github.com/googleapis/java-bigquerystorage/commit/c7da34252ee8c243be3ce737d03e1e12f10a5eba))
* re-generated to pick up changes from googleapis. ([#982](https://www.github.com/googleapis/java-bigquerystorage/issues/982)) ([17bfbd8](https://www.github.com/googleapis/java-bigquerystorage/commit/17bfbd8dffd854356ea503adf3a6e065f1e1a4ee))


### Bug Fixes

* Cleanup JsonWriter bytes conversion code and add some test coverage ([#984](https://www.github.com/googleapis/java-bigquerystorage/issues/984)) ([e43df34](https://www.github.com/googleapis/java-bigquerystorage/commit/e43df3403c4d7644032cef6e1f1cf59e6ec1b5eb))


### Documentation

* update region tag for the storage quickstart ([#985](https://www.github.com/googleapis/java-bigquerystorage/issues/985)) ([1d0d6c3](https://www.github.com/googleapis/java-bigquerystorage/commit/1d0d6c3a877943b83775430d5a2bf7fcd24a1f21))


### Dependencies

* update dependency com.google.cloud:google-cloud-bigquery to v1.127.12 ([#986](https://www.github.com/googleapis/java-bigquerystorage/issues/986)) ([d39bd79](https://www.github.com/googleapis/java-bigquerystorage/commit/d39bd79a69e987baa7721b907cdccb59d1ea4a74))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.21.0 ([#987](https://www.github.com/googleapis/java-bigquerystorage/issues/987)) ([4fa3dbb](https://www.github.com/googleapis/java-bigquerystorage/commit/4fa3dbba64586f6bf943ba67f225fad1b994e5a7))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@yirutang yirutang deleted the readme branch Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants