Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cleanup JsonWriter bytes conversion code and add some test coverage #984

merged 2 commits into from Apr 7, 2021


Copy link

@yirutang yirutang commented Apr 7, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@yirutang yirutang requested review from as code owners Apr 7, 2021
@yirutang yirutang requested a review from steffnay Apr 7, 2021
@product-auto-label product-auto-label bot added the api: bigquerystorage label Apr 7, 2021
@google-cla google-cla bot added the cla: yes label Apr 7, 2021
@yirutang yirutang requested a review from JacobStocklass Apr 7, 2021
Copy link

@stephaniewang526 stephaniewang526 left a comment

Some tests after failing. PTAL @yirutang

Copy link

@JacobStocklass JacobStocklass left a comment

This seems a lot better with Bytes being handled as just JSONArray instead of JSONArray or String like I had it earlier. Makes the testing a lot less confusing.

@stephaniewang526 stephaniewang526 added the kokoro:force-run label Apr 7, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Apr 7, 2021
@stephaniewang526 stephaniewang526 added the automerge label Apr 7, 2021
Copy link

@codecov codecov bot commented Apr 7, 2021

Codecov Report

Merging #984 (4a7e76e) into master (5c8c4e7) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #984      +/-   ##
- Coverage     81.03%   80.99%   -0.04%     
+ Complexity     1046     1045       -1     
  Files            78       78              
  Lines          5669     5668       -1     
  Branches        436      435       -1     
- Hits           4594     4591       -3     
- Misses          889      890       +1     
- Partials        186      187       +1     
Impacted Files Coverage Δ Complexity Δ
...orage/v1alpha2/ 98.48% <100.00%> (ø) 8.00 <0.00> (ø)
...d/bigquery/storage/v1beta2/ 97.10% <100.00%> (-0.03%) 46.00 <1.00> (-1.00)
.../cloud/bigquery/storage/v1alpha2/ 79.95% <0.00%> (-0.44%) 34.00% <0.00%> (ø%)
...bigquery/storage/v1alpha2/ 80.51% <0.00%> (ø) 38.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c8c4e7...4a7e76e. Read the comment docs.

@gcf-merge-on-green gcf-merge-on-green bot merged commit e43df34 into googleapis:master Apr 7, 2021
17 of 18 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Apr 7, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Apr 9, 2021
🤖 I have created a release \*beep\* \*boop\*
## [1.18.0]( (2021-04-09)

### Features

* add deprecated annotation and tag to bq storage alpha api ([#978]( ([c7da342](
* re-generated to pick up changes from googleapis. ([#982]( ([17bfbd8](

### Bug Fixes

* Cleanup JsonWriter bytes conversion code and add some test coverage ([#984]( ([e43df34](

### Documentation

* update region tag for the storage quickstart ([#985]( ([1d0d6c3](

### Dependencies

* update dependency to v1.127.12 ([#986]( ([d39bd79](
* update dependency to v0.21.0 ([#987]( ([4fa3dbb](

This PR was generated with [Release Please]( See [documentation](
@yirutang yirutang deleted the bytes branch Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
api: bigquerystorage cla: yes
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants