Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: migrate to mockito-core 3.12.4 #1008

Merged
merged 6 commits into from Sep 14, 2021
Merged

Conversation

kolea2
Copy link
Collaborator

@kolea2 kolea2 commented Sep 13, 2021

update mockito-all to mockito-core and use the latest version

@product-auto-label product-auto-label bot added the api: bigtable label Sep 13, 2021
@google-cla google-cla bot added the cla: yes label Sep 13, 2021
@kolea2 kolea2 changed the title [wip] deps: migrate to mockito-core 3.12.4 deps: migrate to mockito-core 3.12.4 Sep 14, 2021
@kolea2 kolea2 marked this pull request as ready for review Sep 14, 2021
@kolea2 kolea2 requested review from as code owners Sep 14, 2021
@kolea2 kolea2 added kokoro:force-run and removed kokoro:force-run labels Sep 14, 2021
@eaball35 eaball35 added automerge kokoro:force-run owlbot:run labels Sep 14, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Sep 14, 2021
@eaball35 eaball35 removed the automerge label Sep 14, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Sep 14, 2021
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

lgtm, but please double check the comment below

Timestamp startTime = Timestamp.newBuilder().setSeconds(1234).build();
Timestamp endTime = Timestamp.newBuilder().setSeconds(5678).build();
String operationName = "my-operation";
RestoreTableRequest req = RestoreTableRequest.of(CLUSTER_ID, BACKUP_ID).setTableId(TABLE_ID);
Mockito.when(mockRestoreTableCallable.futureCall(req.toProto(PROJECT_ID, INSTANCE_ID)))
Copy link
Contributor

@igorbernstein2 igorbernstein2 Sep 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bit confused why this can be removed?

Copy link
Collaborator Author

@kolea2 kolea2 Sep 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the only mock actually used in this test was mockRestoreTableOperationCallable. This was getting flagged as unused in a warning.

Copy link
Contributor

@igorbernstein2 igorbernstein2 Sep 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh it seems like its a duplicate of mockOperationResult below

@kolea2 kolea2 merged commit d9f19db into googleapis:master Sep 14, 2021
15 checks passed
@kolea2 kolea2 deleted the mockito-core branch Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants