Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix typo in rst stream message #1029

Merged
merged 2 commits into from Oct 5, 2021
Merged

fix: fix typo in rst stream message #1029

merged 2 commits into from Oct 5, 2021

Conversation

mutianf
Copy link
Contributor

@mutianf mutianf commented Oct 5, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@mutianf mutianf requested a review from as a code owner Oct 5, 2021
@product-auto-label product-auto-label bot added the api: bigtable label Oct 5, 2021
@google-cla google-cla bot added the cla: yes label Oct 5, 2021
@@ -78,7 +78,7 @@ private Throwable convertException(Throwable t) {
// Long lived connections sometimes are disconnected via an RST frame. This error is
// transient and should be retried.
if (t instanceof InternalException) {
if (t.getMessage() != null && t.getMessage().contains("Received Rst stream")) {
if (t.getMessage() != null && t.getMessage().contains("Received Rst Stream")) {
Copy link
Collaborator

@kolea2 kolea2 Oct 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we use a case insensitive comparison?

Copy link
Contributor

@igorbernstein2 igorbernstein2 Oct 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just simplify this to lowercase().contains("rst_stream") || lowercase.contains("rst stream")

kolea2
kolea2 approved these changes Oct 5, 2021
@mutianf mutianf merged commit 50e6860 into googleapis:main Oct 5, 2021
17 checks passed
@mutianf mutianf deleted the nit branch Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants