Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configure branch 2.2.x as a release branch #1044

Merged
merged 9 commits into from Oct 25, 2021
Merged

Conversation

kolea2
Copy link
Collaborator

@kolea2 kolea2 commented Oct 25, 2021

enable releases

@kolea2 kolea2 requested review from as code owners Oct 25, 2021
@google-cla google-cla bot added the cla: yes label Oct 25, 2021
@product-auto-label product-auto-label bot added the api: bigtable label Oct 25, 2021
@generated-files-bot
Copy link

@generated-files-bot generated-files-bot bot commented Oct 25, 2021

Warning: This pull request is touching the following templated files:

  • .github/release-please.yml
  • .github/sync-repo-settings.yaml

@@ -38,19 +38,19 @@ function determineMavenOpts() {
| sed -E 's/^(1\.[0-9]\.0).*$/\1/g'
)

case $javaVersion in
"17")
if [[ $javaVersion == 17* ]]
Copy link
Contributor

@igorbernstein2 igorbernstein2 Oct 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this still relevant?

Copy link
Collaborator Author

@kolea2 kolea2 Oct 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can either wait for the upstream synthtool change or just merge in as is. I was testing here first before making googleapis/synthtool#1266

@kolea2 kolea2 changed the title build: configure branch 2.2.x as a release branch feat: configure branch 2.2.x as a release branch Oct 25, 2021
@kolea2 kolea2 merged commit 68e8790 into main Oct 25, 2021
18 checks passed
@kolea2 kolea2 deleted the release-brancher/2.2.x branch Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants