Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add BigtableDataClientFactory to create lightweight data clients #112

Merged
merged 3 commits into from Jan 6, 2020

Conversation

igorbernstein2
Copy link
Contributor

@igorbernstein2 igorbernstein2 commented Dec 9, 2019

The new factory allows users to construct a single heavy factory object that can create many lightweight clients.
This is meant to be used in situations when a single application needs to access multiple instances or use different application profiles

The new factory allows users to construct a single heavy factory object that can create many lightweight clients.
This is meant to be used in situations when a single application needs to access multiple instances or use different application profiles
@igorbernstein2 igorbernstein2 requested review from rahulKQL and kolea2 Dec 9, 2019
@googlebot googlebot added the cla: yes label Dec 9, 2019
@igorbernstein2
Copy link
Contributor Author

@igorbernstein2 igorbernstein2 commented Dec 9, 2019

@tonytanger Can you take a look as well? I want to make sure this doesn't conflict with your channel refresh work

@codecov
Copy link

@codecov codecov bot commented Dec 9, 2019

Codecov Report

Merging #112 into master will increase coverage by 0.41%.
The diff coverage is 94.11%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #112      +/-   ##
============================================
+ Coverage     81.33%   81.74%   +0.41%     
- Complexity      937      952      +15     
============================================
  Files            95       97       +2     
  Lines          5850     5927      +77     
  Branches        325      327       +2     
============================================
+ Hits           4758     4845      +87     
+ Misses          916      904      -12     
- Partials        176      178       +2
Impacted Files Coverage Δ Complexity Δ
...ble/data/v2/stub/EnhancedBigtableStubSettings.java 94.3% <100%> (+0.55%) 18 <0> (+1) ⬆️
...e/cloud/bigtable/data/v2/BigtableDataSettings.java 67.74% <66.66%> (+35.59%) 7 <0> (+3) ⬆️
...ud/bigtable/data/v2/BigtableDataClientFactory.java 95.55% <95.55%> (ø) 9 <9> (?)
...oud/bigtable/data/v2/models/DefaultRowAdapter.java 96.87% <0%> (-0.05%) 8% <0%> (ø)
...loud/bigtable/data/v2/internal/RefreshChannel.java 40% <0%> (ø) 2% <0%> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aed1d10...cc35ccb. Read the comment docs.

@igorbernstein2 igorbernstein2 added the do not merge label Dec 10, 2019
kolea2
kolea2 approved these changes Dec 11, 2019
@kolea2 kolea2 added the kokoro:force-run label Dec 12, 2019
@tonytanger
Copy link
Contributor

@tonytanger tonytanger commented Dec 12, 2019

LGTM. Don't think primechannel and this will conflict.

@kolea2 kolea2 added kokoro:force-run and removed kokoro:force-run labels Dec 12, 2019
@kokoro-team kokoro-team removed the kokoro:force-run label Dec 12, 2019
@igorbernstein2 igorbernstein2 removed the do not merge label Jan 6, 2020
@igorbernstein2 igorbernstein2 merged commit d6bfd30 into googleapis:master Jan 6, 2020
13 checks passed
@igorbernstein2 igorbernstein2 deleted the client-factory branch Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants