feat: add experimental channel refreshing by tonytanger · Pull Request #115 · googleapis/java-bigtable

tonytanger · 2019-12-12T20:25:34Z

Implement ChannelPrimer to establish connection to the GFE so bigtable client will reconnect to the Cloud Bigtable service periodically before the connection gets terminated.

igorbernstein2 · 2019-12-17T18:28:27Z

As discussed offline

the implementation should be moved to EnhancedStubSettings
the ChannelProvider meddling should be deferred to the construction of EnhancedBigtableStubSettings. Otherwise the customer has to worry about the ordering of setting the channel provider and enabling channel priming

codecov · 2019-12-17T18:33:09Z

Codecov Report

Merging #115 into master will decrease coverage by 0.06%.
The diff coverage is 65.51%.

@@             Coverage Diff              @@
##             master     #115      +/-   ##
============================================
- Coverage     81.29%   81.23%   -0.07%     
- Complexity      937      940       +3     
============================================
  Files            95       96       +1     
  Lines          5849     5878      +29     
  Branches        325      327       +2     
============================================
+ Hits           4755     4775      +20     
- Misses          918      925       +7     
- Partials        176      178       +2

Impacted Files	Coverage Δ	Complexity Δ
...e/cloud/bigtable/data/v2/BigtableDataSettings.java	`30% <0%> (-2.15%)`	`4 <0> (ø)`
...ble/data/v2/stub/EnhancedBigtableStubSettings.java	`94.24% <100%> (+0.49%)`	`18 <1> (+1)`	⬆️
...loud/bigtable/data/v2/internal/RefreshChannel.java	`40% <40%> (ø)`	`2 <2> (?)`
...om/google/cloud/bigtable/emulator/v2/Emulator.java	`60% <0%> (+0.86%)`	`14% <0%> (ø)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12169d6...b9ca9cd. Read the comment docs.

igorbernstein2

LGTM!

Thanks for landing this!

kolea2 · 2019-12-17T20:11:07Z

    String projectId = "my-project";
    String instanceId = "my-instance";
    String appProfileId = "my-app-profile-id";
+    boolean isRefreshingChannel = true;


can you please add a small test for the default (unset) refreshingChannel as well and that it is false?

added 2 tests for default and false

stale review

…GFE and integrate into bigtable client

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 12, 2019

tonytanger force-pushed the add-channel-primer-reconnect-gfe branch 4 times, most recently from 8651577 to 111b544 Compare December 17, 2019 16:12

kolea2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 17, 2019

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 17, 2019

kolea2 previously requested changes Dec 17, 2019

View reviewed changes

Comment thread google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataSettings.java Outdated

tonytanger force-pushed the add-channel-primer-reconnect-gfe branch from 111b544 to 8783ce6 Compare December 17, 2019 18:33

tonytanger force-pushed the add-channel-primer-reconnect-gfe branch from 8783ce6 to 836fdda Compare December 17, 2019 18:39

igorbernstein2 suggested changes Dec 17, 2019

View reviewed changes