Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce google-cloud-bigtable-deps-bom #130

Merged
merged 4 commits into from Jan 6, 2020

Conversation

igorbernstein2
Copy link
Contributor

@igorbernstein2 igorbernstein2 commented Dec 27, 2019

Move all of the dependency version management out of the root pom and into a separate BOM.
This will allow java-bigtable-hbase to sync on dependency versions with java-bigtable.

In addition to moving the dependencyManagement section to a BOM, I imported google-auth-library-bom and fixed the README to point to the correct version of gRPC

Move all of the dependency version management out of the root pom and into a separate BOM.
This will allow java-bigtable-hbase to sync on dependency versions with java-bigtable
@igorbernstein2 igorbernstein2 requested a review from kolea2 Dec 27, 2019
@googlebot googlebot added the cla: yes label Dec 27, 2019
@codecov
Copy link

@codecov codecov bot commented Dec 27, 2019

Codecov Report

Merging #130 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #130   +/-   ##
=========================================
  Coverage     81.25%   81.25%           
  Complexity      940      940           
=========================================
  Files            96       96           
  Lines          5878     5878           
  Branches        327      327           
=========================================
  Hits           4776     4776           
  Misses          924      924           
  Partials        178      178

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da1e6c6...ee1cea3. Read the comment docs.

@kolea2
Copy link
Collaborator

@kolea2 kolea2 commented Jan 2, 2020

CC @chingor13 to see if there are any last thoughts before I approve here

kolea2
kolea2 approved these changes Jan 3, 2020
@igorbernstein2 igorbernstein2 merged commit 9289a13 into googleapis:master Jan 6, 2020
10 of 11 checks passed
@igorbernstein2 igorbernstein2 deleted the deps-bom branch Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants