Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: readme note for gke deployment configuration #185

Merged
merged 2 commits into from Feb 24, 2020

Conversation

rahulKQL
Copy link
Contributor

@rahulKQL rahulKQL commented Jan 31, 2020

Fixes #184

This change contains a note for deployment configuration in GKE. If no configuration
is provided the JVM in CoS detects only 1 CPU/Core, which restrains the
the number of channels resulting in performance loss.

@rahulKQL rahulKQL requested review from igorbernstein2 and kolea2 Jan 31, 2020
@googlebot googlebot added the cla: yes label Jan 31, 2020
@rahulKQL rahulKQL changed the title docs: README note for GKE deployment configuration docs: readme note for gke deployment configuration Jan 31, 2020
rahulKQL added 2 commits Jan 31, 2020
This change contains a note for deployment in GKE. If no configuration
is provided the JVM in CoS detects only 1 CPU/Core, which restrain the
number of channels resulting in performance loss.
Added grpc thread sharing note
@codecov
Copy link

@codecov codecov bot commented Jan 31, 2020

Codecov Report

No coverage uploaded for pull request base (master@7b896dd). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #185   +/-   ##
=========================================
  Coverage          ?   81.95%           
  Complexity        ?      973           
=========================================
  Files             ?       99           
  Lines             ?     6025           
  Branches          ?      331           
=========================================
  Hits              ?     4938           
  Misses            ?      910           
  Partials          ?      177

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b896dd...670381e. Read the comment docs.

@rahulKQL rahulKQL added the kokoro:force-run label Feb 5, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Feb 5, 2020
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

lgtm

@igorbernstein2 igorbernstein2 added the kokoro:force-run label Feb 24, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Feb 24, 2020
@igorbernstein2 igorbernstein2 merged commit 0afa13a into googleapis:master Feb 24, 2020
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants