Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add row exists api #190

Merged
merged 3 commits into from Feb 5, 2020
Merged

feat: add row exists api #190

merged 3 commits into from Feb 5, 2020

Conversation

rahulKQL
Copy link
Contributor

@rahulKQL rahulKQL commented Feb 5, 2020

Fixes #188

Adding a new Row exists() API in BigtableDataClient

Adding a new Row exists() API in `BigtableDataClient`
@googlebot googlebot added the cla: yes label Feb 5, 2020
@rahulKQL rahulKQL requested review from igorbernstein2 and kolea2 Feb 5, 2020
@codecov
Copy link

@codecov codecov bot commented Feb 5, 2020

Codecov Report

No coverage uploaded for pull request base (master@3235a97). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #190   +/-   ##
=========================================
  Coverage          ?   82.05%           
  Complexity        ?      978           
=========================================
  Files             ?       99           
  Lines             ?     6035           
  Branches          ?      332           
=========================================
  Hits              ?     4952           
  Misses            ?      907           
  Partials          ?      176
Impacted Files Coverage Δ Complexity Δ
...gle/cloud/bigtable/data/v2/BigtableDataClient.java 93.54% <100%> (ø) 39 <4> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3235a97...d1f00e8. Read the comment docs.

@rahulKQL rahulKQL marked this pull request as ready for review Feb 5, 2020
@rahulKQL rahulKQL requested a review from igorbernstein2 Feb 5, 2020
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

lgtm

@igorbernstein2 igorbernstein2 merged commit d141c3d into googleapis:master Feb 5, 2020
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants