Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more context to row merging errors #281

Merged
merged 3 commits into from May 6, 2020

Conversation

igorbernstein2
Copy link
Contributor

@igorbernstein2 igorbernstein2 commented May 5, 2020

These errors should never happen. But if they do, it would very useful to get more context as to what rows triggered them

@googlebot googlebot added the cla: yes label May 5, 2020
kolea2
kolea2 approved these changes May 6, 2020
Copy link
Collaborator

@kolea2 kolea2 left a comment

pending more changes

@igorbernstein2
Copy link
Contributor Author

@igorbernstein2 igorbernstein2 commented May 6, 2020

Should be ready now

kolea2
kolea2 approved these changes May 6, 2020
@codecov
Copy link

@codecov codecov bot commented May 6, 2020

Codecov Report

Merging #281 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #281      +/-   ##
============================================
+ Coverage     79.76%   79.82%   +0.06%     
  Complexity      991      991              
============================================
  Files            99       99              
  Lines          6399     6414      +15     
  Branches        319      319              
============================================
+ Hits           5104     5120      +16     
  Misses         1098     1098              
+ Partials        197      196       -1     
Impacted Files Coverage Δ Complexity Δ
...d/bigtable/data/v2/stub/readrows/StateMachine.java 89.58% <100.00%> (+1.98%) 15.00 <3.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1571dd9...cf693a2. Read the comment docs.

@igorbernstein2 igorbernstein2 changed the title chore: add more context to row merging errors feat: add more context to row merging errors May 6, 2020
@igorbernstein2 igorbernstein2 merged commit d88547c into googleapis:master May 6, 2020
15 checks passed
@igorbernstein2 igorbernstein2 deleted the error-detail branch May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants