Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change app_profile_id to the correct header app_profile #318

Merged
merged 1 commit into from May 27, 2020

Conversation

tonytanger
Copy link
Contributor

@tonytanger tonytanger commented May 27, 2020

Fix the header added in #268 to the one being used in experiment.

@googlebot googlebot added the cla: yes label May 27, 2020
@codecov
Copy link

@codecov codecov bot commented May 27, 2020

Codecov Report

Merging #318 into master will increase coverage by 0.33%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #318      +/-   ##
============================================
+ Coverage     80.35%   80.69%   +0.33%     
  Complexity     1049     1049              
============================================
  Files            99       99              
  Lines          6541     6541              
  Branches        343      344       +1     
============================================
+ Hits           5256     5278      +22     
  Misses         1082     1082              
+ Partials        203      181      -22     
Impacted Files Coverage Δ Complexity Δ
...ud/bigtable/data/v2/stub/EnhancedBigtableStub.java 95.74% <100.00%> (ø) 21.00 <0.00> (ø)
...able/admin/v2/BaseBigtableInstanceAdminClient.java 61.46% <0.00%> (+4.39%) 56.00% <0.00%> (ø%)
...igtable/admin/v2/BaseBigtableTableAdminClient.java 62.90% <0.00%> (+4.72%) 67.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f61f90...fe73d2f. Read the comment docs.

@kolea2 kolea2 added the kokoro:force-run label May 27, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label May 27, 2020
kolea2
kolea2 approved these changes May 27, 2020
@kolea2 kolea2 merged commit 237b15d into googleapis:master May 27, 2020
14 checks passed
@release-please release-please bot mentioned this pull request Jun 9, 2020
@release-please release-please bot mentioned this pull request Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants