Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: use google-cloud-shared-dependencies in bigtable deps bom #324

Merged
merged 1 commit into from May 28, 2020

Conversation

kolea2
Copy link
Collaborator

@kolea2 kolea2 commented May 28, 2020

No description provided.

@googlebot googlebot added the cla: yes label May 28, 2020
@kolea2 kolea2 requested a review from igorbernstein2 May 28, 2020
@codecov
Copy link

@codecov codecov bot commented May 28, 2020

Codecov Report

Merging #324 into master will decrease coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #324      +/-   ##
============================================
- Coverage     80.72%   80.36%   -0.36%     
+ Complexity     1050     1049       -1     
============================================
  Files            99       99              
  Lines          6541     6541              
  Branches        344      343       -1     
============================================
- Hits           5280     5257      -23     
+ Misses         1081     1080       -1     
- Partials        180      204      +24     
Impacted Files Coverage Δ Complexity Δ
...igtable/admin/v2/BaseBigtableTableAdminClient.java 58.18% <0.00%> (-4.73%) 67.00% <0.00%> (ø%)
...able/admin/v2/BaseBigtableInstanceAdminClient.java 57.07% <0.00%> (-4.40%) 56.00% <0.00%> (ø%)
...able/gaxx/reframing/ReframingResponseObserver.java 89.28% <0.00%> (-1.79%) 29.00% <0.00%> (-1.00%)
...om/google/cloud/bigtable/emulator/v2/Emulator.java 59.13% <0.00%> (+0.86%) 14.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf23ab6...deb3587. Read the comment docs.

Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

lgtm

@kolea2 kolea2 merged commit 8f76fc8 into googleapis:master May 28, 2020
13 of 14 checks passed
@kolea2 kolea2 deleted the shared-deps-update branch May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants