Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: change app_profile_id to the correct header app_profile" #335

Merged
merged 1 commit into from Jun 9, 2020

Conversation

igorbernstein2
Copy link
Contributor

@igorbernstein2 igorbernstein2 commented Jun 9, 2020

Reverts #318

The header keys should match the request fields

@googlebot googlebot added the cla: yes label Jun 9, 2020
@tonytanger
Copy link
Contributor

@tonytanger tonytanger commented Jun 9, 2020

LGTM!

@codecov
Copy link

@codecov codecov bot commented Jun 9, 2020

Codecov Report

Merging #335 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #335      +/-   ##
============================================
- Coverage     80.70%   80.69%   -0.02%     
  Complexity     1049     1049              
============================================
  Files            99       99              
  Lines          6541     6541              
  Branches        344      344              
============================================
- Hits           5279     5278       -1     
- Misses         1080     1082       +2     
+ Partials        182      181       -1     
Impacted Files Coverage Δ Complexity Δ
...ud/bigtable/data/v2/stub/EnhancedBigtableStub.java 95.74% <100.00%> (ø) 21.00 <0.00> (ø)
...om/google/cloud/bigtable/emulator/v2/Emulator.java 58.26% <0.00%> (-0.87%) 14.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa0b558...3be1de3. Read the comment docs.

kolea2
kolea2 approved these changes Jun 9, 2020
@kolea2 kolea2 merged commit 200cfac into master Jun 9, 2020
13 of 14 checks passed
@kolea2 kolea2 deleted the revert-318-master branch Jun 9, 2020
@release-please release-please bot mentioned this pull request Jun 9, 2020
@release-please release-please bot mentioned this pull request Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants