Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): adopt flatten plugin and google-cloud-shared-dependencies #350

Merged
merged 2 commits into from Aug 31, 2020

Conversation

yangnuoyu
Copy link
Contributor

@yangnuoyu yangnuoyu commented Jun 17, 2020

No description provided.

@googlebot googlebot added the cla: yes label Jun 17, 2020
@codecov
Copy link

@codecov codecov bot commented Jun 17, 2020

Codecov Report

Merging #350 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #350      +/-   ##
============================================
- Coverage     80.26%   80.24%   -0.02%     
  Complexity     1102     1102              
============================================
  Files           105      105              
  Lines          6815     6815              
  Branches        364      364              
============================================
- Hits           5470     5469       -1     
- Misses         1146     1148       +2     
+ Partials        199      198       -1     
Impacted Files Coverage Δ Complexity Δ
...om/google/cloud/bigtable/emulator/v2/Emulator.java 58.26% <0.00%> (-0.87%) 14.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 848affb...ffa5abf. Read the comment docs.

@yangnuoyu yangnuoyu marked this pull request as ready for review Jun 19, 2020
@igorbernstein2
Copy link
Contributor

@igorbernstein2 igorbernstein2 commented Jun 22, 2020

Please attach a diff of how the dependencies change for end users

stephaniewang526
stephaniewang526 previously approved these changes Jun 22, 2020
kolea2
kolea2 previously requested changes Jun 22, 2020
Copy link
Collaborator

@kolea2 kolea2 left a comment

will review once looking at diff

@stephaniewang526
Copy link
Member

@stephaniewang526 stephaniewang526 commented Jun 23, 2020

Please attach a diff of how the dependencies change for end users

@igorbernstein2 there is no change in dependency list for end users -- i added a kokoro check for this in dependencies.sh to ensure accuracy. The only difference is that transitive dependencies are resolved to be direct. i will share my doc with you for further details. Thanks.

@product-auto-label product-auto-label bot added the api: bigtable label Aug 21, 2020
@igorbernstein2
Copy link
Contributor

@igorbernstein2 igorbernstein2 commented Aug 31, 2020

Looking at the main artifact, the proposed change will affect the following deps (by pulling them up to the top level).

[INFO] |  \- javax.annotation:javax.annotation-api:jar:1.3.2:compile

[INFO] |  +- com.google.http-client:google-http-client:jar:1.36.0:compile
[INFO] |  |  +- org.apache.httpcomponents:httpclient:jar:4.5.12:compile
[INFO] |  |  |  +- commons-logging:commons-logging:jar:1.2:compile
[INFO] |  |  |  \- commons-codec:commons-codec:jar:1.11:compile
[INFO] |  |  +- org.apache.httpcomponents:httpcore:jar:4.4.13:compile
[INFO] |  |  \- io.opencensus:opencensus-contrib-http-util:jar:0.24.0:compile
[INFO] |  \- com.google.http-client:google-http-client-jackson2:jar:1.36.0:compile
[INFO] |     \- com.fasterxml.jackson.core:jackson-core:jar:2.11.1:compile

[INFO] |  +- com.google.guava:failureaccess:jar:1.0.1:compile
[INFO] |  +- com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava:compile
[INFO] |  +- org.checkerframework:checker-compat-qual:jar:2.5.5:compile
[INFO] |  +- com.google.errorprone:error_prone_annotations:jar:2.4.0:compile
[INFO] |  \- com.google.j2objc:j2objc-annotations:jar:1.3:compile

[INFO] |  \- com.google.code.gson:gson:jar:2.8.6:compile
[INFO] |  +- org.apache.commons:commons-lang3:jar:3.5:runtime
[INFO] |  \- org.conscrypt:conscrypt-openjdk-uber:jar:2.2.1:runtime

[INFO] |  \- org.codehaus.mojo:animal-sniffer-annotations:jar:1.19:runtime

This means that those libraries might change version in customer applications if bigtable was tied for a version. But I dont see any tangible negative effects that this would have.

I think we can probably merge

@kolea2 kolea2 dismissed their stale review Aug 31, 2020

stale

@kolea2 kolea2 added automerge kokoro:force-run labels Aug 31, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Aug 31, 2020
@kolea2 kolea2 removed the automerge label Aug 31, 2020
@kolea2 kolea2 merged commit 2298596 into googleapis:master Aug 31, 2020
15 of 16 checks passed
gcf-merge-on-green bot pushed a commit that referenced this issue Sep 2, 2020
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.15.0](https://www.github.com/googleapis/java-bigtable/compare/v1.14.0...v1.15.0) (2020-09-01)


### Features

* extend channel priming logic to also send fake requests ([#398](https://www.github.com/googleapis/java-bigtable/issues/398)) ([6f1ead2](https://www.github.com/googleapis/java-bigtable/commit/6f1ead2097150a87cb9712bcf35c6eaa9d57440c))
* **deps:** adopt flatten plugin and google-cloud-shared-dependencies ([#350](https://www.github.com/googleapis/java-bigtable/issues/350)) ([2298596](https://www.github.com/googleapis/java-bigtable/commit/2298596dab8a1ef87c0f48d3abe8bc3955417eb1))


### Bug Fixes

* temporarily disable reporting to unblock releases ([#395](https://www.github.com/googleapis/java-bigtable/issues/395)) ([a56a0f8](https://www.github.com/googleapis/java-bigtable/commit/a56a0f8c9caf675b68d02587b042e1feeb261ccb))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.6 ([#377](https://www.github.com/googleapis/java-bigtable/issues/377)) ([bdae336](https://www.github.com/googleapis/java-bigtable/commit/bdae336074d80815dcaaf8c71befafc0ed66c079))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.9.0 ([#402](https://www.github.com/googleapis/java-bigtable/issues/402)) ([08f7d84](https://www.github.com/googleapis/java-bigtable/commit/08f7d84333c6a74bf03e0a57707b878a29400dd4))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants