Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix maven test configs to make sure admin tests don't clobber data tests #47

Merged
merged 2 commits into from Oct 28, 2019

Conversation

igorbernstein2
Copy link
Contributor

@igorbernstein2 igorbernstein2 commented Oct 28, 2019

No description provided.

@googlebot googlebot added the cla: yes label Oct 28, 2019
<test>com.google.cloud.bigtable.data.v2.it.**</test>
<test>com.google.cloud.bigtable.admin.v2.it.**</test>
<includes>
<include>com.google.cloud.bigtable.data.v2.it.**</include>
Copy link
Collaborator

@kolea2 kolea2 Oct 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to replace this with a one-liner: com.google.cloud.bigtable.**.v2.it.**? Not super familiar with the syntax here but wanted to check!

Copy link
Contributor Author

@igorbernstein2 igorbernstein2 Oct 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, updated. Thanks for the suggestion

@codecov
Copy link

@codecov codecov bot commented Oct 28, 2019

Codecov Report

Merging #47 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #47   +/-   ##
=========================================
  Coverage     81.28%   81.28%           
  Complexity      937      937           
=========================================
  Files            95       95           
  Lines          5839     5839           
  Branches        325      325           
=========================================
  Hits           4746     4746           
  Misses          917      917           
  Partials        176      176

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ca7e2f...85a8160. Read the comment docs.

kolea2
kolea2 approved these changes Oct 28, 2019
Copy link
Collaborator

@kolea2 kolea2 left a comment

LGTM let's just confirm in logs it looks good before merging

@igorbernstein2 igorbernstein2 merged commit 18576f5 into googleapis:master Oct 28, 2019
12 checks passed
@igorbernstein2 igorbernstein2 deleted the fix-test-clobbering branch Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants