fix: readRowSettings use manual readRows settings instead of gapic's #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #494 +/- ##
=========================================
Coverage 81.32% 81.32%
Complexity 1128 1128
=========================================
Files 106 106
Lines 7042 7042
Branches 368 368
=========================================
Hits 5727 5727
Misses 1117 1117
Partials 198 198
Continue to review full report at Codecov.
|
product-auto-label
bot
added
the
api: bigtable
gcf-merge-on-green bot
pushed a commit
that referenced
this issue
Nov 10, 2020
🤖 I have created a release \*beep\* \*boop\* --- ### [1.17.2](https://www.github.com/googleapis/java-bigtable/compare/v1.17.1...v1.17.2) (2020-11-10) ### Bug Fixes * readRowSettings use manual readRows settings instead of gapics ([#494](https://www.github.com/googleapis/java-bigtable/issues/494)) ([0ef7c5d](https://www.github.com/googleapis/java-bigtable/commit/0ef7c5d4aacacd2030a52efc148ead457719a927)) ### Reverts * Revert "feat: attemp DirectPath by default (#467)" (#520) ([b33b0fc](https://www.github.com/googleapis/java-bigtable/commit/b33b0fc1b5478934298db317c1168c1e9dc20599)), closes [#467](https://www.github.com/googleapis/java-bigtable/issues/467) [#520](https://www.github.com/googleapis/java-bigtable/issues/520) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
mutianf
pushed a commit
to mutianf/java-bigtable
that referenced
this issue
Nov 12, 2020
mutianf
pushed a commit
to mutianf/java-bigtable
that referenced
this issue
Nov 12, 2020
🤖 I have created a release \*beep\* \*boop\* --- ### [1.17.2](https://www.github.com/googleapis/java-bigtable/compare/v1.17.1...v1.17.2) (2020-11-10) ### Bug Fixes * readRowSettings use manual readRows settings instead of gapics ([googleapis#494](https://www.github.com/googleapis/java-bigtable/issues/494)) ([0ef7c5d](https://www.github.com/googleapis/java-bigtable/commit/0ef7c5d4aacacd2030a52efc148ead457719a927)) ### Reverts * Revert "feat: attemp DirectPath by default (googleapis#467)" (googleapis#520) ([b33b0fc](https://www.github.com/googleapis/java-bigtable/commit/b33b0fc1b5478934298db317c1168c1e9dc20599)), closes [googleapis#467](https://www.github.com/googleapis/java-bigtable/issues/467) [googleapis#520](https://www.github.com/googleapis/java-bigtable/issues/520) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
ad548
pushed a commit
to ad548/java-bigtable
that referenced
this issue
Mar 13, 2021
ad548
pushed a commit
to ad548/java-bigtable
that referenced
this issue
Mar 13, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [1.17.2](https://www.github.com/googleapis/java-bigtable/compare/v1.17.1...v1.17.2) (2020-11-10) ### Bug Fixes * readRowSettings use manual readRows settings instead of gapics ([googleapis#494](https://www.github.com/googleapis/java-bigtable/issues/494)) ([0ef7c5d](https://www.github.com/googleapis/java-bigtable/commit/0ef7c5d4aacacd2030a52efc148ead457719a927)) ### Reverts * Revert "feat: attemp DirectPath by default (googleapis#467)" (googleapis#520) ([b33b0fc](https://www.github.com/googleapis/java-bigtable/commit/b33b0fc1b5478934298db317c1168c1e9dc20599)), closes [googleapis#467](https://www.github.com/googleapis/java-bigtable/issues/467) [googleapis#520](https://www.github.com/googleapis/java-bigtable/issues/520) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I found that the
readRowsettings were referencing thebaseDefaults(i.e. the defaults in the GAPIC stub settings) forreadRows, rather than the manually overridden settings that are used for theretryableCodesimmediately above. This seems like the safest thing to keep the sources of the RetrySettings all referencing the manually overridden settings.This will also be necessary for an upcoming config change that will make RPCs configured as non-retryable in the GAPIC to be generated without backoff settings (because they are not retryable). @igorbernstein2 this is the change we spoke about.