Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: readRowSettings use manual readRows settings instead of gapic's #494

Merged
merged 1 commit into from Nov 10, 2020

Conversation

noahdietz
Copy link
Contributor

@noahdietz noahdietz commented Oct 23, 2020

I found that the readRow settings were referencing the baseDefaults (i.e. the defaults in the GAPIC stub settings) for readRows, rather than the manually overridden settings that are used for the retryableCodes immediately above. This seems like the safest thing to keep the sources of the RetrySettings all referencing the manually overridden settings.

This will also be necessary for an upcoming config change that will make RPCs configured as non-retryable in the GAPIC to be generated without backoff settings (because they are not retryable). @igorbernstein2 this is the change we spoke about.

@noahdietz noahdietz requested a review from as a code owner Oct 23, 2020
@google-cla google-cla bot added the cla: yes label Oct 23, 2020
@codecov
Copy link

@codecov codecov bot commented Oct 23, 2020

Codecov Report

Merging #494 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #494   +/-   ##
=========================================
  Coverage     81.32%   81.32%           
  Complexity     1128     1128           
=========================================
  Files           106      106           
  Lines          7042     7042           
  Branches        368      368           
=========================================
  Hits           5727     5727           
  Misses         1117     1117           
  Partials        198      198           
Impacted Files Coverage Δ Complexity Δ
...ble/data/v2/stub/EnhancedBigtableStubSettings.java 97.60% <100.00%> (ø) 22.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0f21a2...9ed23f1. Read the comment docs.

@product-auto-label product-auto-label bot added the api: bigtable label Oct 24, 2020
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

lgtm

@igorbernstein2 igorbernstein2 merged commit 0ef7c5d into googleapis:master Nov 10, 2020
19 checks passed
@noahdietz noahdietz deleted the read-row-setting branch Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants