Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow restore backup to different instance #515

Merged
merged 4 commits into from Apr 30, 2021

Conversation

liubonan
Copy link
Contributor

@liubonan liubonan commented Nov 5, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #789
kokoro:force-run

@google-cla google-cla bot added the cla: yes label Nov 5, 2020
@product-auto-label product-auto-label bot added the api: bigtable label Nov 5, 2020
@codecov
Copy link

@codecov codecov bot commented Nov 5, 2020

Codecov Report

Merging #515 (b168074) into master (b4dfddd) will increase coverage by 0.02%.
The diff coverage is 88.23%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #515      +/-   ##
============================================
+ Coverage     83.44%   83.47%   +0.02%     
- Complexity     1311     1314       +3     
============================================
  Files           114      114              
  Lines          7799     7806       +7     
  Branches        442      446       +4     
============================================
+ Hits           6508     6516       +8     
+ Misses         1036     1034       -2     
- Partials        255      256       +1     
Impacted Files Coverage Δ Complexity Δ
.../bigtable/admin/v2/models/RestoreTableRequest.java 82.85% <88.23%> (+4.28%) 10.00 <3.00> (+3.00)
...om/google/cloud/bigtable/emulator/v2/Emulator.java 60.65% <0.00%> (+0.81%) 14.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4dfddd...b168074. Read the comment docs.

@kolea2 kolea2 changed the base branch from master to backup-different-instance Nov 30, 2020
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

prod code looks good, but as @kolea2 pointed out, the integration tests need to be rebased

@generated-files-bot
Copy link

@generated-files-bot generated-files-bot bot commented Jan 15, 2021

Warning: This pull request is touching the following templated files:

  • .github/generated-files-bot.yml
  • .kokoro/release/publish_javadoc.sh
  • samples/install-without-bom/pom.xml
  • samples/snapshot/pom.xml
  • samples/snippets/pom.xml

@snippet-bot
Copy link

@snippet-bot snippet-bot bot commented Jan 15, 2021

Here is the summary of changes.

You added 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cla
Copy link

@google-cla google-cla bot commented Jan 15, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Jan 15, 2021
@google-cla
Copy link

@google-cla google-cla bot commented Jan 20, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

@google-cla google-cla bot commented Jan 20, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

@google-cla google-cla bot commented Jan 20, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@kolea2 kolea2 changed the base branch from backup-different-instance to master Apr 23, 2021
@kolea2
Copy link
Collaborator

@kolea2 kolea2 commented Apr 23, 2021

@google-cla google-cla bot added cla: yes and removed cla: no labels Apr 23, 2021
@kolea2 kolea2 marked this pull request as ready for review Apr 23, 2021
@kolea2 kolea2 requested a review from as a code owner Apr 23, 2021
@kolea2 kolea2 added the kokoro:force-run label Apr 27, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Apr 27, 2021
Change-Id: I3a2bb866d660cc5b6abb5a57b344dfc019c8cdf0
kolea2
kolea2 approved these changes Apr 28, 2021
liubonan added 2 commits Apr 29, 2021
Change-Id: I9d75b3c7135223e0f56266e797201a96efcc86a7
Change-Id: I65a08bcfcdef49478925037066d865e0963b4374
@kolea2 kolea2 added the kokoro:force-run label Apr 30, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Apr 30, 2021
@kolea2 kolea2 added the automerge label Apr 30, 2021
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

lgtm

@gcf-merge-on-green gcf-merge-on-green bot merged commit 8a5e60e into googleapis:master Apr 30, 2021
18 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants