Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: attempt DirectPath by default #544

Merged
merged 2 commits into from Dec 3, 2020
Merged

Conversation

mohanli-ml
Copy link
Contributor

@mohanli-ml mohanli-ml commented Nov 30, 2020

The original PR #467 is revered in #520. Since the bug has been fixed (googleapis/gax-java#1250) and issue has been closed (grpc/grpc-java#7604), we should make the bigtable client attempt DirectPath by default again.

@mohanli-ml mohanli-ml requested a review from as a code owner Nov 30, 2020
@google-cla google-cla bot added the cla: yes label Nov 30, 2020
@product-auto-label product-auto-label bot added the api: bigtable label Nov 30, 2020
@codecov
Copy link

@codecov codecov bot commented Nov 30, 2020

Codecov Report

Merging #544 (71bc2f9) into master (af0da54) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #544      +/-   ##
============================================
+ Coverage     81.26%   81.30%   +0.04%     
+ Complexity     1129     1128       -1     
============================================
  Files           106      106              
  Lines          7045     7040       -5     
  Branches        370      368       -2     
============================================
- Hits           5725     5724       -1     
+ Misses         1121     1119       -2     
+ Partials        199      197       -2     
Impacted Files Coverage Δ Complexity Δ
...ble/data/v2/stub/EnhancedBigtableStubSettings.java 97.59% <100.00%> (+1.52%) 22.00 <0.00> (-1.00) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af0da54...71bc2f9. Read the comment docs.

@kolea2 kolea2 changed the title feat: attemp DirectPath by default feat: attempt DirectPath by default Dec 1, 2020
Copy link
Collaborator

@kolea2 kolea2 left a comment

This looks good but we can't merge/release until the shared dependencies BOM is released with the updated gax version. Adding do not merge label for now

@kolea2 kolea2 added do not merge and removed do not merge labels Dec 1, 2020
kolea2
kolea2 approved these changes Dec 3, 2020
@kolea2 kolea2 merged commit 2043063 into googleapis:master Dec 3, 2020
19 checks passed
gcf-merge-on-green bot pushed a commit that referenced this issue Dec 3, 2020
ad548 pushed a commit to ad548/java-bigtable that referenced this issue Mar 13, 2021
ad548 pushed a commit to ad548/java-bigtable that referenced this issue Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants