Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix MetricTracerTest to rebase on head #581

Merged
merged 1 commit into from Dec 17, 2020
Merged

fix: fix MetricTracerTest to rebase on head #581

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 6 additions & 2 deletions ...table/src/test/java/com/google/cloud/bigtable/data/v2/stub/metrics/MetricsTracerTest.java
View file
Open in desktop
Expand Up @@ -338,11 +338,15 @@ public void testInvalidRequest() throws InterruptedException {
Thread.sleep(100);
// Verify that the latency is recorded with an error code (in this case UNKNOWN)
long attemptLatency =
getAggregationValueAsLong(
StatsTestUtils.getAggregationValueAsLong(
localStats,
RpcViewConstants.BIGTABLE_ATTEMPT_LATENCY_VIEW,
ImmutableMap.of(
RpcMeasureConstants.BIGTABLE_OP, TagValue.create("Bigtable.MutateRows"),
RpcMeasureConstants.BIGTABLE_STATUS, TagValue.create("UNKNOWN")));
RpcMeasureConstants.BIGTABLE_STATUS, TagValue.create("UNKNOWN")),
PROJECT_ID,
INSTANCE_ID,
APP_PROFILE_ID);
assertThat(attemptLatency).isAtLeast(0);
}
}
Expand Down