Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent integration tests from different profiles from clobbering each other #69

merged 1 commit into from Nov 7, 2019


Copy link

@igorbernstein2 igorbernstein2 commented Nov 6, 2019

The integration tests in this project can target multiple environments: emulator, cloud, etc. This is implemented using profiles. To avoid conflicts, the summary reports were suffixed by the profile name. Unfortunately the individual test reports were not and each profile would overwrite the previous reports. This PR gives each profile its own directory.

Also, it fixes up the setup script

@igorbernstein2 igorbernstein2 added the type: bug label Nov 6, 2019
@igorbernstein2 igorbernstein2 requested a review from kolea2 Nov 6, 2019
@googlebot googlebot added the cla: yes label Nov 6, 2019
Copy link

@codecov codecov bot commented Nov 6, 2019

Codecov Report

Merging #69 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #69   +/-   ##
  Coverage     81.29%   81.29%           
  Complexity      937      937           
  Files            95       95           
  Lines          5842     5842           
  Branches        325      325           
  Hits           4749     4749           
  Misses          917      917           
  Partials        176      176

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5aa8769...32c0626. Read the comment docs.

kolea2 approved these changes Nov 7, 2019
@kolea2 kolea2 merged commit 638615a into googleapis:master Nov 7, 2019
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
cla: yes type: bug
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants