Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dynamic flow control #721

Merged
merged 5 commits into from Apr 13, 2021
Merged

feat: dynamic flow control #721

merged 5 commits into from Apr 13, 2021

Conversation

mutianf
Copy link
Contributor

@mutianf mutianf commented Apr 12, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

mutianf added 2 commits Apr 12, 2021
* feat: dynamic flow control p1, add settings

* update documents

* move flow controller instantiation to stub.create

* fix test

* add some tests

* split out settings to BatchCallSettings

* add getters for target rpc latency

* fix doc

* more changes in doc

* update document and checks on parameters

* add more docs on flow control configs

* fix test

* split up enable/disable settings
* feat: dynamic flow control for bulk mutation batcher

* improve documents

* add integration test

* clean up tests and formatting

* add more comments

* moved FlowControlEventStats into FlowController

* updates based on review p1

* updates based on review p2

* updates on review

* update constant
@mutianf mutianf requested a review from as a code owner Apr 12, 2021
@google-cla google-cla bot added the cla: yes label Apr 12, 2021
@product-auto-label product-auto-label bot added the api: bigtable label Apr 12, 2021
@mutianf mutianf added the kokoro:force-run label Apr 12, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Apr 12, 2021
@codecov
Copy link

@codecov codecov bot commented Apr 12, 2021

Codecov Report

Merging #721 (b032931) into master (67ef155) will increase coverage by 0.09%.
The diff coverage is 87.07%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #721      +/-   ##
============================================
+ Coverage     83.64%   83.73%   +0.09%     
- Complexity     1220     1238      +18     
============================================
  Files           112      114       +2     
  Lines          7417     7594     +177     
  Branches        394      422      +28     
============================================
+ Hits           6204     6359     +155     
- Misses         1010     1018       +8     
- Partials        203      217      +14     
Impacted Files Coverage Δ Complexity Δ
...ble/data/v2/stub/EnhancedBigtableStubSettings.java 97.66% <ø> (ø) 23.00 <0.00> (ø)
...d/bigtable/data/v2/stub/metrics/MetricsTracer.java 83.54% <ø> (ø) 16.00 <0.00> (ø)
...e/cloud/bigtable/data/v2/BigtableDataSettings.java 67.50% <50.00%> (-1.95%) 8.00 <0.00> (ø)
...table/data/v2/stub/DynamicFlowControlCallable.java 75.92% <75.92%> (ø) 3.00 <3.00> (?)
...ble/data/v2/stub/BigtableBatchingCallSettings.java 95.00% <92.75%> (-5.00%) 9.00 <4.00> (+4.00) ⬇️
...bigtable/data/v2/stub/DynamicFlowControlStats.java 97.29% <97.29%> (ø) 8.00 <8.00> (?)
...ud/bigtable/data/v2/stub/EnhancedBigtableStub.java 97.04% <100.00%> (+0.11%) 29.00 <1.00> (+3.00)
...om/google/cloud/bigtable/emulator/v2/Emulator.java 60.65% <0.00%> (+0.81%) 14.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67ef155...b032931. Read the comment docs.

Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

lgtm

@igorbernstein2 igorbernstein2 merged commit b61c5ce into master Apr 13, 2021
18 checks passed
@igorbernstein2 igorbernstein2 deleted the dynamic_flow_control branch Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants