Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): correct docs for CUSTOMER_MANAGED_ENCRYPTION #737

Merged
merged 2 commits into from Apr 19, 2021

Conversation

kolea2
Copy link
Collaborator

@kolea2 kolea2 commented Apr 19, 2021

@kolea2 kolea2 requested a review from as a code owner Apr 19, 2021
@product-auto-label product-auto-label bot added the api: bigtable label Apr 19, 2021
@google-cla google-cla bot added the cla: yes label Apr 19, 2021
@codecov
Copy link

@codecov codecov bot commented Apr 19, 2021

Codecov Report

Merging #737 (450cf5f) into master (3fa8b00) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #737      +/-   ##
============================================
+ Coverage     83.64%   83.73%   +0.08%     
- Complexity     1220     1238      +18     
============================================
  Files           112      114       +2     
  Lines          7417     7593     +176     
  Branches        394      422      +28     
============================================
+ Hits           6204     6358     +154     
- Misses         1010     1018       +8     
- Partials        203      217      +14     
Impacted Files Coverage Δ Complexity Δ
...cloud/bigtable/admin/v2/models/EncryptionInfo.java 77.77% <ø> (ø) 8.00 <0.00> (ø)
...ble/data/v2/stub/BigtableBatchingCallSettings.java 95.00% <0.00%> (-5.00%) 9.00% <0.00%> (+4.00%) ⬇️
...e/cloud/bigtable/data/v2/BigtableDataSettings.java 67.50% <0.00%> (-1.95%) 8.00% <0.00%> (ø%)
...d/bigtable/data/v2/stub/metrics/MetricsTracer.java 83.54% <0.00%> (ø) 16.00% <0.00%> (ø%)
...ble/data/v2/stub/EnhancedBigtableStubSettings.java 97.66% <0.00%> (ø) 23.00% <0.00%> (ø%)
...n/templates/com/google/cloud/bigtable/Version.java
...c/main/java/com/google/cloud/bigtable/Version.java 50.00% <0.00%> (ø) 1.00% <0.00%> (?%)
...bigtable/data/v2/stub/DynamicFlowControlStats.java 97.29% <0.00%> (ø) 8.00% <0.00%> (?%)
...table/data/v2/stub/DynamicFlowControlCallable.java 75.92% <0.00%> (ø) 3.00% <0.00%> (?%)
...ud/bigtable/data/v2/stub/EnhancedBigtableStub.java 97.03% <0.00%> (+0.10%) 29.00% <0.00%> (+3.00%)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fa8b00...450cf5f. Read the comment docs.

ad548
ad548 approved these changes Apr 19, 2021
@kolea2 kolea2 merged commit b3bb7f7 into googleapis:master Apr 19, 2021
18 checks passed
@kolea2 kolea2 deleted the cmek-docs-fix branch Apr 19, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants