Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix flaky test #798

Merged
merged 1 commit into from May 6, 2021
Merged

fix: fix flaky test #798

merged 1 commit into from May 6, 2021

Conversation

mutianf
Copy link
Contributor

@mutianf mutianf commented May 6, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@mutianf mutianf requested a review from as a code owner May 6, 2021
@google-cla google-cla bot added the cla: yes label May 6, 2021
@product-auto-label product-auto-label bot added the api: bigtable label May 6, 2021
@codecov
Copy link

@codecov codecov bot commented May 6, 2021

Codecov Report

Merging #798 (928bc2a) into master (be81ef8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #798   +/-   ##
=========================================
  Coverage     83.46%   83.46%           
- Complexity     1314     1315    +1     
=========================================
  Files           114      114           
  Lines          7806     7806           
  Branches        446      446           
=========================================
  Hits           6515     6515           
  Misses         1036     1036           
  Partials        255      255           
Impacted Files Coverage Δ Complexity Δ
...ata/v2/stub/metrics/HeaderTracerUnaryCallable.java 89.47% <0.00%> (ø) 3.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be81ef8...928bc2a. Read the comment docs.

@mutianf mutianf merged commit 83e0e8c into googleapis:master May 6, 2021
18 checks passed
@mutianf mutianf deleted the flaky_test branch May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants