Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Experimental DirectPath support #8

Merged
merged 6 commits into from Oct 24, 2019

Conversation

igorbernstein2
Copy link
Contributor

@igorbernstein2 igorbernstein2 commented Oct 17, 2019

Previously DirectPath support was enabled only in a test profile. Now the support is being pulled into the actually client. This functionality is currently in private alpha testing and will only be available to some customers. A lot of the changes in this PR are temporary, and will be removed once DirectPath goes public using the default endpoint.

The endpoint hasn't rolled out yet, but I was able to confirm that this works with the old test endpoint. The new endpoint should be live tomorrow

@googlebot googlebot added the cla: yes label Oct 17, 2019
@codecov
Copy link

@codecov codecov bot commented Oct 22, 2019

Codecov Report

Merging #8 into master will decrease coverage by 0.11%.
The diff coverage is 35.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #8      +/-   ##
============================================
- Coverage      81.1%   80.99%   -0.12%     
  Complexity      914      914              
============================================
  Files            93       93              
  Lines          5701     5714      +13     
  Branches        302      307       +5     
============================================
+ Hits           4624     4628       +4     
- Misses          919      925       +6     
- Partials        158      161       +3
Impacted Files Coverage Δ Complexity Δ
...ble/data/v2/stub/EnhancedBigtableStubSettings.java 93.49% <35.71%> (-5.23%) 17 <1> (ø)
...able/data/v2/stub/GrpcBigtableCallableFactory.java 37.5% <0%> (ø) 3% <0%> (ø) ⬇️
...v2/stub/GrpcBigtableTableAdminCallableFactory.java 50% <0%> (ø) 4% <0%> (ø) ⬇️
...igtable/admin/v2/BaseBigtableTableAdminClient.java 60.8% <0%> (ø) 48% <0%> (ø) ⬇️
.../cloud/bigtable/data/v2/stub/GrpcBigtableStub.java 93.28% <0%> (ø) 11% <0%> (ø) ⬇️
...ogle/cloud/bigtable/data/v2/stub/BigtableStub.java 14.28% <0%> (ø) 1% <0%> (ø) ⬇️
...able/admin/v2/BaseBigtableInstanceAdminClient.java 62.3% <0%> (ø) 54% <0%> (ø) ⬇️
...stub/GrpcBigtableInstanceAdminCallableFactory.java 50% <0%> (ø) 4% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6789e80...43ebcda. Read the comment docs.

@igorbernstein2 igorbernstein2 changed the title WIP: Add Experimental DirectPath support Add Experimental DirectPath support Oct 22, 2019
@igorbernstein2 igorbernstein2 marked this pull request as ready for review Oct 22, 2019
@igorbernstein2 igorbernstein2 requested review from crwilcox and kolea2 Oct 22, 2019
kolea2
kolea2 approved these changes Oct 23, 2019
@kolea2
Copy link
Collaborator

@kolea2 kolea2 commented Oct 23, 2019

lgtm after code format

@kolea2 kolea2 changed the title Add Experimental DirectPath support feat: Add Experimental DirectPath support Oct 24, 2019
@igorbernstein2 igorbernstein2 merged commit 2dd5105 into googleapis:master Oct 24, 2019
10 of 12 checks passed
@igorbernstein2 igorbernstein2 deleted the dp-support branch Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants