Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude protobuf from conformance-tests #845

Merged
merged 2 commits into from May 27, 2021
Merged

Conversation

mutianf
Copy link
Contributor

@mutianf mutianf commented May 27, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@mutianf mutianf requested review from as code owners May 27, 2021
@google-cla google-cla bot added the cla: yes label May 27, 2021
@product-auto-label product-auto-label bot added the api: bigtable label May 27, 2021
@mutianf mutianf requested a review from igorbernstein2 May 27, 2021
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

lgtm

@mutianf mutianf merged commit 1d89191 into googleapis:master May 27, 2021
16 checks passed
@mutianf mutianf deleted the version branch May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants