Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gapic-generator-java v1.0.12, mtls support #871

Merged
merged 2 commits into from Aug 5, 2021

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 馃寛

Synth log will be available here:
https://source.cloud.google.com/results/invocations/c004b0a6-793a-4a2d-87c2-4f1a0e72dbc2/targets

  • To automatically regenerate this PR, check this box. (May take up to 24 hours.)

PiperOrigin-RevId: 378718217
Source-Link: googleapis/googleapis@08c4eeb

Committer: @miraleung
PiperOrigin-RevId: 378718217

Source-Author: Google APIs <noreply@google.com>
Source-Date: Thu Jun 10 13:08:49 2021 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 08c4eeb531c01ad031134dca94b18e3f7dd35902
Source-Link: googleapis/googleapis@08c4eeb
@yoshi-automation yoshi-automation requested review from a team as code owners June 10, 2021 22:02
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 10, 2021
@snippet-bot
Copy link

snippet-bot bot commented Jun 10, 2021

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable API. label Jun 10, 2021
@Neenu1995 Neenu1995 added the automerge Merge the pull request once unit tests and other checks pass. label Jun 11, 2021
Neenu1995
Neenu1995 previously approved these changes Jun 11, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed automerge Merge the pull request once unit tests and other checks pass. labels Jun 11, 2021
@kolea2 kolea2 dismissed Neenu1995鈥檚 stale review June 24, 2021 18:09

not ready for merge

@igorbernstein2 igorbernstein2 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 29, 2021
@igorbernstein2
Copy link
Contributor

The gapic pr: googleapis/sdk-platform-java#672
clientside doc: go/java-gapic-client-mtls

@igorbernstein2
Copy link
Contributor

This needs a bit more work:

  • ensure that bigtable is ready for mtls
  • setup an integration test profile that exercises it
  • possible changes to EnhancedBigtableStub

@kolea2 kolea2 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 5, 2021
@kolea2 kolea2 changed the title chore: release gapic-generator-java v1.0.12 feat: release gapic-generator-java v1.0.12 Aug 5, 2021
@kolea2 kolea2 changed the title feat: release gapic-generator-java v1.0.12 feat: gapic-generator-java v1.0.12, mtls support Aug 5, 2021
@kolea2 kolea2 merged commit 3ec05d4 into master Aug 5, 2021
@kolea2 kolea2 deleted the autosynth-googleapis branch August 5, 2021 16:02
gcf-merge-on-green bot pushed a commit that referenced this pull request Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. cla: yes This human has signed the Contributor License Agreement. context: full
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants