Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: call setting timeouts for batchers #877

Merged
merged 1 commit into from Jun 22, 2021

Conversation

igorbernstein2
Copy link
Contributor

@igorbernstein2 igorbernstein2 commented Jun 17, 2021

This unreverts #861 (but without the point read bits)

This introduces 2 new variants of new*Batcher that accept a GrpcCallContext. This context will be used for batch RPCs generated by the batcher instance.
Also fixes handlings of timeout overrides for bukmutations. If a user set a timeout, don't override it

@igorbernstein2 igorbernstein2 requested review from as code owners Jun 17, 2021
@google-cla google-cla bot added the cla: yes label Jun 17, 2021
@product-auto-label product-auto-label bot added the api: bigtable label Jun 17, 2021
This introduces 2 new variants of new*Batcher that accept a GrpcCallContext. This context will be used for batch RPCs generated by the batcher instance.
Also fixes handlings of timeout overrides for bukmutations. If a user set a timeout, don't override it
@igorbernstein2 igorbernstein2 merged commit 0f3654d into googleapis:master Jun 22, 2021
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants