Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: update java compile to 1.8 (update google-cloud-shared-config … #939

Merged
merged 2 commits into from Aug 6, 2021

Conversation

kolea2
Copy link
Collaborator

@kolea2 kolea2 commented Aug 6, 2021

…to v1, google-cloud-shared-dependencies to v2)

Opening in favor of #933 and #928

…to v1, google-cloud-shared-dependencies to v2)
@kolea2 kolea2 requested review from as code owners Aug 6, 2021
@product-auto-label product-auto-label bot added the api: bigtable label Aug 6, 2021
@google-cla google-cla bot added the cla: yes label Aug 6, 2021
@kolea2 kolea2 added the do not merge label Aug 6, 2021
@kolea2 kolea2 removed the do not merge label Aug 6, 2021
mutianf
mutianf approved these changes Aug 6, 2021
@kolea2 kolea2 merged commit 57cddee into googleapis:master Aug 6, 2021
17 checks passed
@kolea2 kolea2 deleted the j8-deps-update branch Aug 6, 2021
@release-please release-please bot mentioned this pull request Aug 6, 2021
igorbernstein2 added a commit to igorbernstein2/java-bigtable that referenced this issue Aug 9, 2021
googleapis#939 switch guava from -android to -jre, which replaced the transitive dep checker-compat-qual with checker-qual. This introduced a version conflict between guava's transitive deps and truth's: gauva depends on version 3.8.0 while truth depends on 3.13.0. googleapis#939 tried to workaround the conflict by excluding the transitive dep from truth, but it didnt do it all places. This finishes the workaround.

I'm not convinced that this is the correct way to resolve the dependency conflict, but for now this PR just makes it consistent
gcf-merge-on-green bot pushed a commit that referenced this issue Aug 9, 2021
#939 switch guava from -android to -jre, which replaced the transitive dep checker-compat-qual with checker-qual. This introduced a version conflict between guava's transitive deps and truth's: gauva depends on version 3.8.0 while truth depends on 3.13.0. #939 tried to workaround the conflict by excluding the transitive dep from truth, but it didnt do it all places. This finishes the workaround.

I'm not convinced that this is the correct way to resolve the dependency conflict, but for now this PR just makes it consistent
gcf-merge-on-green bot pushed a commit that referenced this issue Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants