Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate TransferableSkus field #44

Merged
merged 2 commits into from Feb 23, 2021
Merged

Conversation

yoshi-automation
Copy link
Contributor

@yoshi-automation yoshi-automation commented Feb 22, 2021

This PR was generated using Autosynth. 馃寛

Synth log will be available here:
https://source.cloud.google.com/results/invocations/679a8fed-21f3-4860-990c-bf5199c9e87f/targets

  • To automatically regenerate this PR, check this box.

PiperOrigin-RevId: 358862009
Source-Link: googleapis/googleapis@2916ac4

BREAKING CHANGE: TransferableSkus field deprecation. Okay to make this change since no clients are using the libraries that were released just last week. The fields were supposed to be deprecated but missed. We have communicated to clients about this change.

鈥recation. Okay to make this change since no clients are using the libraries that were released just last week. The fields were supposed to be deprecated but missed. We have communicated to clients about this change.

PiperOrigin-RevId: 358862009

Source-Author: Google APIs <noreply@google.com>
Source-Date: Mon Feb 22 11:20:45 2021 -0800
Source-Repo: googleapis/googleapis
Source-Sha: 2916ac4a35c49441baa5dc8c7e2ad5a1205ed2ca
Source-Link: googleapis/googleapis@2916ac4
@yoshi-automation yoshi-automation requested a review from as a code owner Feb 22, 2021
@product-auto-label product-auto-label bot added the api: cloudchannel label Feb 22, 2021
@google-cla google-cla bot added the cla: yes label Feb 22, 2021
@codecov
Copy link

@codecov codecov bot commented Feb 22, 2021

Codecov Report

Merging #44 (3318f49) into master (8496f5e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #44   +/-   ##
=========================================
  Coverage     82.50%   82.50%           
  Complexity      177      177           
=========================================
  Files             6        6           
  Lines          2183     2183           
  Branches         12       12           
=========================================
  Hits           1801     1801           
  Misses          366      366           
  Partials         16       16           
Impacted Files Coverage 螖 Complexity 螖
...le/cloud/channel/v1/CloudChannelServiceClient.java 82.74% <酶> (酶) 75.00 <0.00> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 8496f5e...5391940. Read the comment docs.

@Neenu1995 Neenu1995 changed the title docs: Documentation update BREAKING CHANGE: TransferableSkus field deprecation. Okay to make this change since no clients are using the libraries that were released just last week. The fields were supposed to be deprecated but missed. We have communi feat: deprecate TransferableSkus field Feb 23, 2021
@Neenu1995 Neenu1995 added the automerge label Feb 23, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 3acf948 into master Feb 23, 2021
15 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the autosynth-googleapis branch Feb 23, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Feb 23, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Feb 24, 2021
馃 I have created a release \*beep\* \*boop\* 
---
## [1.1.0](https://www.github.com/googleapis/java-channel/compare/v1.0.1...v1.1.0) (2021-02-24)


###  BREAKING CHANGES

* TransferableSkus field deprecation. Okay to make this change since no clients are using the libraries that were released just last week. The fields were supposed to be deprecated but missed. We have communicated to clients about this change.

### Features

* deprecate TransferableSkus field ([#44](https://www.github.com/googleapis/java-channel/issues/44)) ([3acf948](https://www.github.com/googleapis/java-channel/commit/3acf94818273c3676b0df6cae063ab977b8f0fef))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudchannel cla: yes context: full
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants