Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add queue_ttl to Build, invert_regex to RepoSource #100

Merged
merged 5 commits into from Mar 20, 2020

Conversation

vam-google
Copy link
Contributor

@vam-google vam-google commented Mar 19, 2020

The changes in grpc stubs are caused by the gRPC upgrade from 1.10 (more than a year old) to 1.27 (same version which is used as runtime dependency).

The change in license year is caused by moving to bazel_library method, which uses templates with updated year. Base on our discussion this morning, I assume it is still ok (given that github history prevails).

The changes in grpc stubs are caused by the gRPC upgrade from 1.10 (more than a year old) to 1.27 (same version which is used as runtime dependency)
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 19, 2020
@vam-google
Copy link
Contributor Author

vam-google commented Mar 19, 2020

@chingor13 PTAL

@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #100 into master will increase coverage by 2.34%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #100      +/-   ##
============================================
+ Coverage     77.56%   79.91%   +2.34%     
- Complexity       84       99      +15     
============================================
  Files             6        6              
  Lines           682      682              
  Branches          2        2              
============================================
+ Hits            529      545      +16     
+ Misses          151      135      -16     
  Partials          2        2
Impacted Files Coverage Δ Complexity Δ
...oud/devtools/cloudbuild/v1/CloudBuildSettings.java 11.86% <ø> (ø) 2 <0> (ø) ⬇️
...cloud/devtools/cloudbuild/v1/CloudBuildClient.java 84.11% <ø> (+10.28%) 46 <0> (+10) ⬆️
...evtools/cloudbuild/v1/stub/GrpcCloudBuildStub.java 96.6% <ø> (+1.88%) 22 <0> (+5) ⬆️
...ols/cloudbuild/v1/stub/CloudBuildStubSettings.java 83.55% <ø> (ø) 25 <0> (ø) ⬇️
...udbuild/v1/stub/GrpcCloudBuildCallableFactory.java 37.5% <ø> (ø) 3 <0> (ø) ⬇️
...ud/devtools/cloudbuild/v1/stub/CloudBuildStub.java 5.55% <ø> (ø) 1 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 972aae8...4945d50. Read the comment docs.

Copy link
Contributor

@chingor13 chingor13 left a comment

This seems to include new client code as well.

We need to add a proto-google-cloud-build-v1/clirr-ignored-differences.xml file with:

<?xml version="1.0" encoding="UTF-8"?>
<!-- see http://www.mojohaus.org/clirr-maven-plugin/examples/ignored-differences.html -->
<differences>
  <difference>
    <differenceType>7012</differenceType>
    <className>com/google/cloudbuild/v1/*OrBuilder</className>
    <method>* get*(*)</method>
  </difference>
  <difference>
    <differenceType>7012</differenceType>
    <className>com/google/cloudbuild/v1/*OrBuilder</className>
    <method>boolean contains*(*)</method>
  </difference>
  <difference>
    <differenceType>7012</differenceType>
    <className>com/google/cloudbuild/v1/*OrBuilder</className>
    <method>boolean has*(*)</method>
  </difference>
</differences>

vam-google added 2 commits Mar 19, 2020
The changes in grpc stubs are caused by the gRPC upgrade from 1.10 (more than a year old) to 1.27 (same version which is used as runtime dependency)
The changes in grpc stubs are caused by the gRPC upgrade from 1.10 (more than a year old) to 1.27 (same version which is used as runtime dependency)
@vam-google
Copy link
Contributor Author

vam-google commented Mar 19, 2020

@chingor13 PTAL (all tests passed)

@chingor13 chingor13 changed the title chore: Migrate cloudbuild synth.py to bazel feat: add queue_ttl to Build, invert_regex to RepoSource Mar 20, 2020
@chingor13 chingor13 merged commit db14077 into googleapis:master Mar 20, 2020
15 checks passed
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 30, 2020
yoshi-automation added a commit that referenced this pull request Mar 31, 2020
e44ccd9
commit e44ccd9
Author: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Date:   Mon Mar 30 22:38:07 2020 +0000

    chore: release 1.1.0 (#102)

    🤖 I have created a release \*beep\* \*boop\*
    ---
    ## [1.1.0](https://www.github.com/googleapis/java-cloudbuild/compare/v1.0.3...v1.1.0) (2020-03-30)

    ### Features

    * add queue_ttl to Build, invert_regex to RepoSource ([#100](https://www.github.com/googleapis/java-cloudbuild/issues/100)) ([db14077](https://www.github.com/googleapis/java-cloudbuild/commit/db14077a07f54a260d26483868866b16b200cd2b))

    ### Dependencies

    * update dependency com.google.api:api-common to v1.9.0 ([#112](https://www.github.com/googleapis/java-cloudbuild/issues/112)) ([76452e2](https://www.github.com/googleapis/java-cloudbuild/commit/76452e288e5d4215057c369e21102009b9ca27b1))
    ---

    This PR was generated with [Release Please](https://github.com/googleapis/release-please).
yoshi-automation added a commit that referenced this pull request Apr 1, 2020
e44ccd9
commit e44ccd9
Author: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Date:   Mon Mar 30 22:38:07 2020 +0000

    chore: release 1.1.0 (#102)

    🤖 I have created a release \*beep\* \*boop\*
    ---
    ## [1.1.0](https://www.github.com/googleapis/java-cloudbuild/compare/v1.0.3...v1.1.0) (2020-03-30)

    ### Features

    * add queue_ttl to Build, invert_regex to RepoSource ([#100](https://www.github.com/googleapis/java-cloudbuild/issues/100)) ([db14077](https://www.github.com/googleapis/java-cloudbuild/commit/db14077a07f54a260d26483868866b16b200cd2b))

    ### Dependencies

    * update dependency com.google.api:api-common to v1.9.0 ([#112](https://www.github.com/googleapis/java-cloudbuild/issues/112)) ([76452e2](https://www.github.com/googleapis/java-cloudbuild/commit/76452e288e5d4215057c369e21102009b9ca27b1))
    ---

    This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants