Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: release scripts from issuing overlapping phases #456

Merged
merged 1 commit into from Apr 15, 2021

Conversation

yoshi-automation
Copy link
Contributor

@yoshi-automation yoshi-automation commented Apr 14, 2021

This PR was generated using Autosynth. 馃寛

Synth log will be available here:
https://source.cloud.google.com/results/invocations/dfb66b55-3396-437c-ad70-9f7c5c769e4b/targets

  • To automatically regenerate this PR, check this box. (May take up to 24 hours.)

Source-Link: googleapis/synthtool@8285c2b

`mvn deploy` will run `mvn install` so specifying `mvn install deploy` is redundant at best. At worst, it will cause plugins like maven-shade-plugin to be executed twice re-shading itself

Source-Author: Igor Bernstein <igorbernstein@google.com>
Source-Date: Wed Apr 14 13:16:03 2021 -0400
Source-Repo: googleapis/synthtool
Source-Sha: 8285c2b4cdbc3771d031ad91e1c4ec9e55fff45d
Source-Link: googleapis/synthtool@8285c2b
@yoshi-automation yoshi-automation requested review from a team as code owners Apr 14, 2021
@product-auto-label product-auto-label bot added the api: cloudbuild Issues related to the googleapis/java-cloudbuild API. label Apr 14, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 14, 2021
@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #456 (2f6c6f8) into master (91b5eed) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #456   +/-   ##
=========================================
  Coverage     82.68%   82.68%           
  Complexity      121      121           
=========================================
  Files             6        6           
  Lines           976      976           
  Branches          3        3           
=========================================
  Hits            807      807           
  Misses          166      166           
  Partials          3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 91b5eed...2f6c6f8. Read the comment docs.

@Neenu1995 Neenu1995 added the automerge Merge the pull request once unit tests and other checks pass. label Apr 15, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit ad05975 into master Apr 15, 2021
18 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the autosynth-synthtool branch Apr 15, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 15, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Apr 27, 2021
馃 I have created a release \*beep\* \*boop\*
---
## [2.4.0](https://www.github.com/googleapis/java-cloudbuild/compare/v2.3.1...v2.4.0) (2021-04-23)


### Features

* Add fields for Pub/Sub triggers ([#457](https://www.github.com/googleapis/java-cloudbuild/issues/457)) ([55b10de](https://www.github.com/googleapis/java-cloudbuild/commit/55b10de722d09d8a861fc1325eeda14a208add15))


### Bug Fixes

* release scripts from issuing overlapping phases ([#456](https://www.github.com/googleapis/java-cloudbuild/issues/456)) ([ad05975](https://www.github.com/googleapis/java-cloudbuild/commit/ad0597543005b36650c577490f8a93a5511fa1c2))
* typo ([#453](https://www.github.com/googleapis/java-cloudbuild/issues/453)) ([dffb9db](https://www.github.com/googleapis/java-cloudbuild/commit/dffb9db12cc0f557031e1509c5ff13239443e6ba))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.21.1 ([#460](https://www.github.com/googleapis/java-cloudbuild/issues/460)) ([d34cd4d](https://www.github.com/googleapis/java-cloudbuild/commit/d34cd4d347e637c847900ada7aca788608c69fb8))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v1 ([#463](https://www.github.com/googleapis/java-cloudbuild/issues/463)) ([82711b3](https://www.github.com/googleapis/java-cloudbuild/commit/82711b36eeeebf187566586e9e2d6441e074562b))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudbuild Issues related to the googleapis/java-cloudbuild API. cla: yes This human has signed the Contributor License Agreement. context: full
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants