This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
Classes in Java artifact do not match the protos shipped with it #134
Labels
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Comments
Neenu1995
added
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
labels
Mar 29, 2021
Thanks for bringing this to our attention. Our automation to update the generated code is not correctly copying the associated proto files with it. |
@chingor13 Is there any update on this? Thanks |
Seconding the question on updates. |
@chingor13 is there any good news upcoming on this ticket? Thanks |
@chingor13 I'm seeing the same issue with the latest 2.2.1 release where |
gcf-merge-on-green bot
pushed a commit
that referenced
this issue
May 20, 2021
The proto files were not in sync with the java files shipped with the artidact Id. Now the protos get copied directly from googleapis to java-common-protos repo to keep them in sync with each other. Fixes #134
gcf-merge-on-green bot
pushed a commit
that referenced
this issue
May 20, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [2.3.0](https://www.github.com/googleapis/java-common-protos/compare/v2.2.2...v2.3.0) (2021-05-20) ### Features * update protos in the repo from googleapis ([#169](https://www.github.com/googleapis/java-common-protos/issues/169)) ([abd8291](https://www.github.com/googleapis/java-common-protos/commit/abd8291f0983f3412b3a259444845530163f6643)), closes [#134](https://www.github.com/googleapis/java-common-protos/issues/134) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced May 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
In the 2.1.0 jar, google/api/endpoint.proto contains a
repeated string features = 4
, however the corresponding Java class file doesn't have any of the methods corresponding to this field.Steps to reproduce
It looks like getters for
features
are not there. Seemingly the code has been generated with a different version of the protos.The text was updated successfully, but these errors were encountered: