Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate java files for extended_operations.proto #200

merged 4 commits into from Aug 26, 2021


Copy link

@Neenu1995 Neenu1995 commented Aug 26, 2021

feat: generate java files for error_reason.proto and localized_text.proto

BigqueryAuditMetadata is being explicitly removed because it is introducing a circular dependency with iam.Policy.
common-protos cannot depend on iam because iam depends on common protos.
This issue needs to be resolved before BigqueryAuditMetadata can be added to the java-common-protos

@Neenu1995 Neenu1995 requested a review from as a code owner Aug 26, 2021
Copy link

generated-files-bot bot commented Aug 26, 2021

Warning: This pull request is touching the following templated files:

  • .github/workflows/ci.yaml
  • .kokoro/
  • .kokoro/nightly/integration.cfg
  • .kokoro/nightly/samples.cfg
  • proto-google-common-protos/src/main/proto/google/cloud/audit/bigquery_audit_metadata.proto

@google-cla google-cla bot added the cla: yes label Aug 26, 2021
@Neenu1995 Neenu1995 added automerge and removed automerge labels Aug 26, 2021
Copy link

@vam-google vam-google left a comment

LGTM, but maybe update the description, because it also regenerates ErrorReasons

@Neenu1995 Neenu1995 added the automerge label Aug 26, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit fec9c81 into master Aug 26, 2021
15 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the add-extended-proto branch Aug 26, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Aug 26, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Aug 26, 2021
🤖 I have created a release \*beep\* \*boop\*
## [2.4.0]( (2021-08-26)

### Features

* add new FieldBehavior NON_EMPTY_DEFAULT ([#191]( ([acb2206](
* Add the `principal` field to the ServiceAccountDelegationInfo proto ([#183]( ([b558909](
* generate java files for extended_operations.proto ([#200]( ([fec9c81](

### Bug Fixes

* Add `shopt -s nullglob` to dependencies script ([#189]( ([89605e8](
* Update to not break on mac ([#186]( ([ae73232](

### Documentation

* modify some field level comments with new details and examples ([b558909](

### Dependencies

* update dependency to v3.17.3 ([#185]( ([6f1b209](
* update dependency io.grpc:grpc-bom to v1.38.1 ([#187]( ([1086c1c](

This PR was generated with [Release Please]( See [documentation](
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
cla: yes
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants